fix(49426): Object method snippet completions incorrectly add this parameters#49757
Merged
gabritto merged 3 commits intomicrosoft:mainfrom Jul 5, 2022
Merged
fix(49426): Object method snippet completions incorrectly add this parameters#49757gabritto merged 3 commits intomicrosoft:mainfrom
gabritto merged 3 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Milestone Bug
gabritto
requested changes
Jul 4, 2022
Member
gabritto
left a comment
gabritto
left a comment
There was a problem hiding this comment.
Left a comment on adding an equivalent type flag, but the rest looks good. I'll also try to get someone else to review it to make sure we're ok with adding a new NodeBuilderFlag.
gabritto
reviewed
Jul 5, 2022
weswigham
approved these changes
Jul 5, 2022
gabritto
approved these changes
Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49426