Fix typechecking related lints that changed post 4.8, update LKG to 4.8.2#50472
Merged
jakebailey merged 3 commits intomicrosoft:mainfrom Aug 26, 2022
Merged
Fix typechecking related lints that changed post 4.8, update LKG to 4.8.2#50472jakebailey merged 3 commits intomicrosoft:mainfrom
jakebailey merged 3 commits intomicrosoft:mainfrom
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0715791 updated our workspace TS to 4.8, which changed which TS that ESLint used. These two cases are type assertions that aren't needed anymore in 4.8 with the new narrowing tweaks.
This PR will fail to build because our LKG is too old; I will update the PR with that shortly (I just wanted to see the CI fail). EDIT: Updated.