remove rogue debugger statement #51997
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Contributor
|
See #46883. It's intentional. |
Member
|
If TypeScript is debug asserting, then something is seriously wrong; this statement is intentional and is very very useful in debugging the codebase. |
sandersn
requested changes
Jan 9, 2023
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
See previous comments. This is intentional.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51998
When debugging something else I found this rogue debugger in the typescript code.
I couldn't find an issue in the backlog that covers this but I figured the PR is just as good as an issue to describe and catalogue the issue 👍Turns out the bot wanted me to open an issue so I did.While opening the issue I found out that this was added a long time ago somewhat intentionally #5358 so I wonder if there might be an alternative solution to allow people to block here if they wanted to: maybe we could wrap the debugger in an if-statement that checks an ENV variable. That way people who wanted to block on this debugger could run their build with
BLOCK_ON_ASSERT_FAILURE=trueand have the same behaviour as now.