Skip to content

Conversation

@sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Jan 21, 2023

Deprecated since #22067

@typescript-bot
Copy link
Collaborator

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @mjbvz, and @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 21, 2023
@sandersn sandersn requested a review from zkat February 1, 2023 19:01
@sandersn
Copy link
Member

sandersn commented Feb 1, 2023

Code itself looks good to me, but @mjbvz and @zkat should probably sign off for VS Code and VS respectively.

@jakebailey
Copy link
Member

I do see one reference to this call from the same list as #52346 (comment) but it's in a long-dead project, so probably not a problem?

@sandersn
Copy link
Member

@sheetalkamat I'm going through all the ready-to-merge PRs, and this one seems worthwhile to merge. Given @jakebailey 's findings we might not need confirmation from @mjbvz or @zkat. What do you think?

@zkat
Copy link
Contributor

zkat commented Mar 1, 2023

I don't see any references to this in VS

@sheetalkamat sheetalkamat merged commit dcc766f into main Mar 1, 2023
@sheetalkamat sheetalkamat deleted the removeOccurences branch March 1, 2023 18:59
@DanielRosenwasser
Copy link
Member

Can you please update https://github.com/microsoft/TypeScript/wiki/API-Breaking-Changes ?

@sheetalkamat sheetalkamat added the Breaking Change Would introduce errors in existing code label Mar 1, 2023
@jakebailey
Copy link
Member

This broke Monaco, because they use occurrences: https://github.com/microsoft/TypeScript-Make-Monaco-Builds/actions/runs/4308395883/jobs/7514631424

Can we revert this until we get a replacement into Monaco? We can't produce any playground builds at the moment.

@jakebailey
Copy link
Member

@jakebailey
Copy link
Member

I sent microsoft/monaco-editor#3619 so hopefully that's looked at soonish, but otherwise we might want to revert?

sheetalkamat added a commit that referenced this pull request Mar 1, 2023
@sheetalkamat
Copy link
Member Author

#53056 if we need to revert

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team Breaking Change Would introduce errors in existing code For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants