Skip to content

Fixed declaration emit for undefined properties inferred from functions in other array elements #53938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
weswigham merged 1 commit into from
May 24, 2023
Merged

Fixed declaration emit for undefined properties inferred from functions in other array elements #53938

weswigham merged 1 commit into from
May 24, 2023

Conversation

@Andarist
Copy link
Contributor

@Andarist Andarist commented Apr 20, 2023

fixes #53914

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Apr 20, 2023
Andarist
Andarist commented Apr 20, 2023
View reviewed changes
src/compiler/checker.ts
Comment on lines +7157 to +7159
if (signatures.length || !optionalToken) {
return;
}
Copy link
Contributor Author

@Andarist Andarist Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the fix, the rest is just dedented because now we fallthrough to the rest of the logic in this case

Copy link
Member

@jakebailey jakebailey May 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To that end, handy better diff link: https://github.com/microsoft/TypeScript/pull/53938/files?w=1

@sandersn sandersn requested review from jakebailey and weswigham May 2, 2023 23:40
jakebailey
jakebailey reviewed May 2, 2023
View reviewed changes
@jakebailey
Copy link
Member

jakebailey commented May 3, 2023

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster
@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 3, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at c981931. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 3, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at c981931. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 3, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at c981931. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 3, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the extended test suite on this PR at c981931. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 3, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the tarball bundle task on this PR at c981931. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 3, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at c981931. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 3, 2023 •
edited
Loading

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/153795/artifacts?artifactName=tgz&fileId=5A5F0C606140380DF133B81D27D63F426024E7CDA62E48D738AFE3CC00ADF42102&fileName=/typescript-5.1.0-insiders.20230503.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.1.0-pr-53938-7".;

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 3, 2023

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/53938/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Unknown failure"
  • 1 instance of "Package install failed"

Otherwise...

Everything looks good!

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 4, 2023

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53938

Metric main 53938 Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 365,245k (± 0.01%) 365,249k (± 0.01%) ~ 365,207k 365,297k p=0.936 n=6
Parse Time 3.56s (± 0.88%) 3.55s (± 0.52%) ~ 3.53s 3.57s p=0.459 n=6
Bind Time 1.18s (± 0.44%) 1.18s (± 1.03%) ~ 1.17s 1.20s p=0.533 n=6
Check Time 9.61s (± 0.61%) 9.54s (± 0.38%) -0.06s (- 0.66%) 9.49s 9.58s p=0.043 n=6
Emit Time 7.97s (± 0.72%) 7.94s (± 0.99%) ~ 7.88s 8.06s p=0.332 n=6
Total Time 22.32s (± 0.48%) 22.20s (± 0.54%) ~ 22.11s 22.38s p=0.065 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,691k (± 0.01%) 192,780k (± 0.02%) +89k (+ 0.05%) 192,726k 192,827k p=0.005 n=6
Parse Time 1.59s (± 1.42%) 1.59s (± 1.22%) ~ 1.55s 1.60s p=1.000 n=6
Bind Time 0.83s (± 0.90%) 0.82s (± 0.63%) ~ 0.82s 0.83s p=0.069 n=6
Check Time 10.38s (± 0.21%) 10.31s (± 0.31%) -0.07s (- 0.64%) 10.26s 10.35s p=0.006 n=6
Emit Time 3.02s (± 0.41%) 3.02s (± 0.50%) ~ 3.00s 3.03s p=1.000 n=6
Total Time 15.81s (± 0.29%) 15.74s (± 0.09%) -0.07s (- 0.46%) 15.72s 15.76s p=0.029 n=6
Monaco - node (v16.17.1, x64)
Memory used 345,851k (± 0.00%) 345,841k (± 0.01%) ~ 345,812k 345,865k p=0.575 n=6
Parse Time 2.73s (± 0.51%) 2.72s (± 0.39%) ~ 2.70s 2.73s p=0.161 n=6
Bind Time 1.09s (± 0.47%) 1.08s (± 0.70%) ~ 1.07s 1.09s p=0.247 n=6
Check Time 7.88s (± 0.44%) 7.86s (± 0.37%) ~ 7.82s 7.89s p=0.170 n=6
Emit Time 4.50s (± 1.01%) 4.47s (± 0.58%) ~ 4.44s 4.51s p=0.199 n=6
Total Time 16.20s (± 0.50%) 16.12s (± 0.10%) ~ 16.10s 16.14s p=0.065 n=6
TFS - node (v16.17.1, x64)
Memory used 300,123k (± 0.01%) 300,101k (± 0.01%) ~ 300,076k 300,124k p=0.172 n=6
Parse Time 2.14s (± 0.48%) 2.15s (± 0.81%) ~ 2.13s 2.18s p=1.000 n=6
Bind Time 1.24s (± 0.72%) 1.24s (± 1.59%) ~ 1.22s 1.27s p=0.458 n=6
Check Time 7.29s (± 0.32%) 7.29s (± 0.55%) ~ 7.24s 7.34s p=0.936 n=6
Emit Time 4.39s (± 0.93%) 4.38s (± 0.51%) ~ 4.34s 4.40s p=0.871 n=6
Total Time 15.06s (± 0.21%) 15.05s (± 0.26%) ~ 15.00s 15.10s p=0.872 n=6
material-ui - node (v16.17.1, x64)
Memory used 481,588k (± 0.01%) 481,602k (± 0.02%) ~ 481,553k 481,752k p=0.810 n=6
Parse Time 3.25s (± 0.45%) 3.23s (± 0.23%) -0.02s (- 0.62%) 3.22s 3.24s p=0.032 n=6
Bind Time 0.94s (± 0.43%) 0.93s (± 0.59%) ~ 0.93s 0.94s p=0.054 n=6
Check Time 17.93s (± 0.35%) 17.81s (± 0.58%) ~ 17.73s 18.01s p=0.065 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.13s (± 0.30%) 21.98s (± 0.52%) -0.15s (- 0.66%) 21.89s 22.20s p=0.045 n=6
xstate - node (v16.17.1, x64)
Memory used 560,400k (± 0.01%) 560,394k (± 0.03%) ~ 560,269k 560,631k p=0.575 n=6
Parse Time 3.99s (± 0.53%) 3.98s (± 0.26%) ~ 3.96s 3.99s p=0.167 n=6
Bind Time 1.77s (± 0.00%) 1.76s (± 0.43%) -0.01s (- 0.66%) 1.75s 1.77s p=0.009 n=6
Check Time 3.07s (± 0.89%) 3.06s (± 0.34%) ~ 3.05s 3.08s p=0.935 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 4.62%) ~ 0.08s 0.09s p=0.405 n=6
Total Time 8.92s (± 0.47%) 8.89s (± 0.15%) ~ 8.87s 8.91s p=0.145 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 53938 6
Baseline main 6

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 4, 2023

Hey @jakebailey, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 4, 2023

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/53938/merge:

Everything looks good!

@weswigham weswigham merged commit 1518cd9 into microsoft:main May 24, 2023
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakebailey jakebailey jakebailey left review comments

@weswigham weswigham weswigham approved these changes

Assignees

@weswigham weswigham

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing property when inferring from object literals in array literals

4 participants

@Andarist @jakebailey @typescript-bot @weswigham