Add CI job that detects unused baselines #54141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
commented
May 5, 2023
.github/workflows/ci.yml
Outdated
| run: | | ||
| if ! git diff --exit-code --quiet; then | ||
| echo "::group::npm test" | ||
| npm test |
Member
Author
There was a problem hiding this comment.
This extra test ensures that the tests still pass after the baselines are removed. But, I think I'm going to drop this, because theoretically anyone who fails this pass will delete the unused baselines and then push their code up, having it rerun.
Member
Author
There was a problem hiding this comment.
(This was really only a concern when we still had baselines that weren't produced by npm test, e.g. the docker and user baselines, which I have since removed.)
Member
Author
|
Just to show before I fix them: https://github.com/microsoft/TypeScript/actions/runs/4895891571/jobs/8742024956?pr=54141 |
sheetalkamat
approved these changes
May 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can catch things like #54140.