Skip to content

Conversation

@andrewbranch
Copy link
Member

#54506 oversimplified things a little by always sending absolute paths to createProgram. When running tsc without a tsconfig file, root names for the program are actually CWD-relative, like src/index.ts. Compiler tests that use non-absolute // @Filename comments previously did this. With this PR,

This causes some paths in baselines to show up with tests/cases/compiler added to them. It doesn’t seem like it’s necessary to keep that fake directory anymore. It would simplify things a lot to remove it. I’ll look into doing that in a subsequent commit or another PR.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 6, 2023
@andrewbranch andrewbranch merged commit d5a6c8e into main Jun 7, 2023
@andrewbranch andrewbranch deleted the test-harness-fixes branch June 7, 2023 00:22
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants