Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#54506 oversimplified things a little by always sending absolute paths to
createProgram. When runningtscwithout a tsconfig file, root names for the program are actually CWD-relative, likesrc/index.ts. Compiler tests that use non-absolute// @Filenamecomments previously did this. With this PR,createProgram(as introduced in Process only tsconfig-referenced files in compiler tests with tsconfig files #54506)createProgramunless the// @Filenameis specified absolute (reverting change from Process only tsconfig-referenced files in compiler tests with tsconfig files #54506)// @Filenamefiles havetests/cases/compilerprepended to them// @outDir: out) havetests/cases/compilerprepended to themcompilerOptionspassed tocreateProgramthen have paths converted to absolute,as always happens with
tsc(Process only tsconfig-referenced files in compiler tests with tsconfig files #54506 missed this)This causes some paths in baselines to show up with
tests/cases/compileradded to them. It doesn’t seem like it’s necessary to keep that fake directory anymore. It would simplify things a lot to remove it. I’ll look into doing that in a subsequent commit or another PR.