Remove allowComplexConstraintInference in inferTypes#54815
Merged
jakebailey merged 1 commit intomicrosoft:mainfrom Aug 15, 2023
Merged
Remove allowComplexConstraintInference in inferTypes#54815jakebailey merged 1 commit intomicrosoft:mainfrom
jakebailey merged 1 commit intomicrosoft:mainfrom
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Andarist
reviewed
Jun 28, 2023
| // (in addition to the extra stack depth here) which, in turn, can push the already close process over its limit. | ||
| // TL;DR: If we ever become generally more memory efficient (or our resource budget ever increases), we should just | ||
| // remove this `allowComplexConstraintInference` flag. | ||
| allowComplexConstraintInference = false; |
Contributor
There was a problem hiding this comment.
quite wild that it was only ever set to false and never reset back to true 😅
Member
Author
There was a problem hiding this comment.
It's local to this infer stack, so it's not like the worst thing in the world.
Contributor
There was a problem hiding this comment.
Aaah, makes sense - I missed that this is a closure variable.
Member
There was a problem hiding this comment.
Yeah, it was basically used so we'd only explore one level of this kind of inference per infer call. So long as RWC no longer OOMs, we're good. We didn't need this to stop runaway memory utilization, but rather just to reduce it by like 5% because RWC at the time was just above memory limits (and we'd has issues with, eg, UMDWeb and fp-ts OOM'ing consistently) with the added inference, and looking into across-the-board memory utilization, rather than just limiting the most recent change, was painful.
Member
Author
|
@typescript-bot test this |
Collaborator
|
Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at b0bca3d. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at b0bca3d. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @jakebailey, I've started to run the extended test suite on this PR at b0bca3d. You can monitor the build here. |
Collaborator
|
Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at b0bca3d. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @jakebailey, I've started to run the perf test suite on this PR at b0bca3d. You can monitor the build here. Update: The results are in! |
Collaborator
|
@jakebailey Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Details
|
Collaborator
|
@jakebailey Here they are:
CompilerComparison Report - main..54815
System
Hosts
Scenarios
TSServerComparison Report - main..54815
System
Hosts
Scenarios
StartupComparison Report - main..54815
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Collaborator
|
Hey @jakebailey, the results of running the DT tests are ready. |
Collaborator
|
@jakebailey Here are the results of running the top-repos suite comparing Everything looks good! |
typescript-bot
added
For Backlog Bug
Member
Author
|
Seems like everything passes? Even RWC? Probably not a good idea to stick post-beta though. |
weswigham
approved these changes
Jun 28, 2023
Member
Author
|
Merging, since it's early 5.3 and I feel safer doing so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27244
This TODO was added many many years ago but was never revisited; the tests pass with this removed but I'm curious what the extended test suites say.