Add handling for json parse errors in tsconfig#5589
Merged
weswigham merged 2 commits intomicrosoft:masterfrom Nov 10, 2015
Merged
Add handling for json parse errors in tsconfig#5589weswigham merged 2 commits intomicrosoft:masterfrom
weswigham merged 2 commits intomicrosoft:masterfrom
Conversation
Contributor
|
👍 |
Contributor
|
this change looks good. Maybe since you are already changing this part of the code you can add better error message for cases when tsconfig.json file is missing (#4590)? |
Member
Author
|
@vladima done. |
Contributor
|
👍 |
weswigham
added a commit
that referenced
this pull request
Nov 10, 2015
Add handling for json parse errors in tsconfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we would error within
parseJsonConfigFileContenton an attempt to index anundefinedvalue whenever we returned an error fromparseConfigFileTextToJson(Which occurs anytime atsconfig.jsonfile has malformed JSON).Also fixes #4590