Deprecate `.hasRestElement` in favor of `combinedFlags` #58864

Andarist · 2024-06-14T19:42:54Z

Just putting this up for discussion, @weswigham has expressed an interest in this here 😉

typescript-bot · 2024-06-14T19:42:57Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

typescript-bot · 2024-06-14T19:43:06Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

weswigham

I'm down for this deprecation (since I proposed it) - @jakebailey ? @ahejlsberg ? @sandersn ? Y'all seem like you'd have the most interest in the tuple element API.

jakebailey · 2024-06-14T20:25:08Z

I think it's fine, though the name being "Variable" makes me quite confused.

I would also say that we should drop the prop entirely and then strap it back on with a getter in the deprecation helpers, but that sounds pretty hard to do for Types.

…ement

sandersn · 2024-06-17T13:37:50Z

though the name being "Variable" makes me quite confused.
The enum is full of so many overlapping concepts that Variable is a pretty good choice. The only change I can think of is 'VariadicOrRest', which isn't really an improvement.

sandersn · 2024-06-17T13:39:06Z

@typescript-bot test it

typescript-bot · 2024-06-17T13:39:10Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-06-17T14:02:47Z

Hey @sandersn, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-06-17T14:05:43Z

@sandersn Here are the results of running the user tests with tsc comparing main and refs/pull/58864/merge:

Everything looks good!

typescript-bot · 2024-06-17T14:21:44Z

@sandersn
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,338k (± 0.97%)}	_{192,217k (± 0.08%)}	_~	_192,126k	_192,537k	_{p=0.810 n=6}
_{Parse Time}	_{1.30s (± 0.79%)}	_{1.31s (± 0.64%)}	_~	_1.29s	_1.31s	_{p=0.672 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.44s (± 0.60%)}	_{9.47s (± 0.66%)}	_~	_9.35s	_9.52s	_{p=0.377 n=6}
_{Emit Time}	_{2.74s (± 0.50%)}	_{2.75s (± 0.67%)}	_~	_2.73s	_2.77s	_{p=0.805 n=6}
_{Total Time}	_{14.20s (± 0.40%)}	_{14.24s (± 0.48%)}	_~	_14.12s	_14.32s	_{p=0.173 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,104	_944,104	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,044	_407,044	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,327k (± 0.01%)}	_{1,218,348k (± 0.00%)}	_~	_1,218,292k	_1,218,443k	_{p=1.000 n=6}
_{Parse Time}	_{6.66s (± 0.65%)}	_{6.66s (± 0.48%)}	_~	_6.63s	_6.71s	_{p=0.871 n=6}
_{Bind Time}	_{1.88s (± 0.62%)}	_{1.87s (± 0.71%)}	_~	_1.85s	_1.88s	_{p=0.209 n=6}
_{Check Time}	_{30.69s (± 0.46%)}	_{30.68s (± 0.14%)}	_~	_30.64s	_30.76s	_{p=1.000 n=6}
_{Emit Time}	_{13.65s (± 0.33%)}	_{13.67s (± 0.32%)}	_~	_13.60s	_13.71s	_{p=0.422 n=6}
_{Total Time}	_{52.87s (± 0.31%)}	_{52.89s (± 0.09%)}	_~	_52.83s	_52.95s	_{p=0.936 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,132,326	_2,132,326	_~	_~	_~	_{p=1.000 n=6}
_Types	_926,744	_926,744	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,115,189k (± 0.01%)}	_{2,115,203k (± 0.00%)}	_~	_2,115,133k	_2,115,347k	_{p=0.298 n=6}
_{Parse Time}	_{6.61s (± 0.23%)}	_{6.62s (± 0.11%)}	_~	_6.61s	_6.63s	_{p=0.120 n=6}
_{Bind Time}	_{2.33s (± 0.47%)}	_{2.34s (± 0.35%)}	_{+0.01s (+ 0.57%)}	_2.34s	_2.36s	_{p=0.024 n=6}
_{Check Time}	_{71.15s (± 0.39%)}	_{70.70s (± 1.38%)}	_~	_68.82s	_71.42s	_{p=0.630 n=6}
_{Emit Time}	_{0.13s (± 3.10%)}	_{0.14s (± 4.05%)}	_~	_0.13s	_0.14s	_{p=0.282 n=6}
_{Total Time}	_{80.22s (± 0.36%)}	_{79.80s (± 1.21%)}	_~	_77.94s	_80.53s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,955	_1,230,955	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,256	_261,256	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,345,465k (± 0.03%)}	_{2,345,203k (± 0.06%)}	_~	_2,343,412k	_2,346,894k	_{p=1.000 n=6}
_{Parse Time}	_{4.99s (± 1.00%)}	_{4.95s (± 0.46%)}	_~	_4.93s	_4.99s	_{p=0.092 n=6}
_{Bind Time}	_{1.89s (± 0.64%)}	_{1.89s (± 0.78%)}	_~	_1.87s	_1.91s	_{p=0.564 n=6}
_{Check Time}	_{33.92s (± 0.22%)}	_{33.87s (± 0.32%)}	_~	_33.67s	_33.99s	_{p=0.468 n=6}
_{Emit Time}	_{2.70s (± 3.22%)}	_{2.73s (± 5.04%)}	_~	_2.58s	_2.97s	_{p=0.810 n=6}
_{Total Time}	_{43.53s (± 0.34%)}	_{43.46s (± 0.45%)}	_~	_43.19s	_43.75s	_{p=0.575 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,955	_1,230,955	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,256	_261,256	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,423,261k (± 0.04%)}	_{2,422,646k (± 0.05%)}	_~	_2,420,853k	_2,424,055k	_{p=0.575 n=6}
_{Parse Time}	_{7.69s (± 0.68%)}	_{7.74s (± 1.36%)}	_~	_7.59s	_7.85s	_{p=0.520 n=6}
_{Bind Time}	_{2.50s (± 0.60%)}	_{2.50s (± 0.78%)}	_~	_2.48s	_2.53s	_{p=1.000 n=6}
_{Check Time}	_{49.78s (± 0.33%)}	_{49.76s (± 0.22%)}	_~	_49.65s	_49.90s	_{p=1.000 n=6}
_{Emit Time}	_{3.88s (± 3.48%)}	_{3.90s (± 3.57%)}	_~	_3.77s	_4.13s	_{p=0.936 n=6}
_{Total Time}	_{63.85s (± 0.23%)}	_{63.91s (± 0.46%)}	_~	_63.49s	_64.24s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,666	_258,666	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,900	_104,900	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{428,270k (± 0.00%)}	_{428,261k (± 0.01%)}	_~	_428,226k	_428,293k	_{p=0.471 n=6}
_{Parse Time}	_{3.31s (± 0.76%)}	_{3.31s (± 0.96%)}	_~	_3.27s	_3.36s	_{p=1.000 n=6}
_{Bind Time}	_{1.30s (± 1.29%)}	_{1.31s (± 1.04%)}	_~	_1.29s	_1.33s	_{p=0.314 n=6}
_{Check Time}	_{17.85s (± 0.51%)}	_{17.87s (± 0.22%)}	_~	_17.81s	_17.91s	_{p=0.574 n=6}
_{Emit Time}	_{1.38s (± 2.79%)}	_{1.36s (± 1.01%)}	_~	_1.34s	_1.38s	_{p=0.517 n=6}
_{Total Time}	_{23.83s (± 0.51%)}	_{23.85s (± 0.22%)}	_~	_23.80s	_23.92s	_{p=0.810 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,401k (± 0.02%)}	_{369,434k (± 0.02%)}	_~	_369,346k	_369,577k	_{p=0.471 n=6}
_{Parse Time}	_{2.77s (± 0.87%)}	_{2.77s (± 0.65%)}	_~	_2.75s	_2.79s	_{p=0.801 n=6}
_{Bind Time}	_{1.59s (± 0.73%)}	_{1.60s (± 1.28%)}	_~	_1.59s	_1.64s	_{p=0.655 n=6}
_{Check Time}	_{15.47s (± 0.32%)}	_{15.52s (± 0.29%)}	_~	_15.47s	_15.58s	_{p=0.199 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.84s (± 0.23%)}	_{19.90s (± 0.29%)}	_~	_19.81s	_19.96s	_{p=0.106 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,861,122	_2,861,122	_~	_~	_~	_{p=1.000 n=6}
_Types	_969,800	_969,800	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,025,332k (± 0.00%)}	_{3,025,367k (± 0.00%)}	_~	_3,025,325k	_3,025,409k	_{p=0.093 n=6}
_{Parse Time}	_{16.64s (± 0.35%)}	_{16.64s (± 0.38%)}	_~	_16.58s	_16.74s	_{p=0.936 n=6}
_{Bind Time}	_{5.01s (± 0.44%)}	_{5.01s (± 0.24%)}	_~	_5.00s	_5.03s	_{p=1.000 n=6}
_{Check Time}	_{88.28s (± 1.41%)}	_{89.10s (± 2.30%)}	_~	_87.77s	_93.21s	_{p=0.173 n=6}
_{Emit Time}	_{28.61s (± 4.19%)}	_{28.03s (± 6.51%)}	_~	_24.45s	_29.10s	_{p=0.336 n=6}
_{Total Time}	_{138.54s (± 0.31%)}	_{138.79s (± 0.26%)}	_~	_138.41s	_139.24s	_{p=0.298 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_266,914	_266,914	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,685	_108,685	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,285k (± 0.02%)}	_{411,274k (± 0.02%)}	_~	_411,204k	_411,418k	_{p=0.575 n=6}
_{Parse Time}	_{3.81s (± 0.32%)}	_{3.81s (± 0.40%)}	_~	_3.78s	_3.82s	_{p=0.934 n=6}
_{Bind Time}	_{1.68s (± 1.02%)}	_{1.69s (± 0.79%)}	_~	_1.67s	_1.71s	_{p=0.410 n=6}
_{Check Time}	_{16.79s (± 0.31%)}	_{16.82s (± 0.32%)}	_~	_16.77s	_16.92s	_{p=0.470 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.28s (± 0.18%)}	_{22.32s (± 0.24%)}	_~	_22.25s	_22.39s	_{p=0.336 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_523,429	_523,429	_~	_~	_~	_{p=1.000 n=6}
_Types	_177,955	_177,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{461,629k (± 0.08%)}	_{461,746k (± 0.07%)}	_~	_461,101k	_461,941k	_{p=0.298 n=6}
_{Parse Time}	_{3.17s (± 0.61%)}	_{3.15s (± 0.75%)}	_~	_3.12s	_3.19s	_{p=0.089 n=6}
_{Bind Time}	_1.19s	_{1.19s (± 0.34%)}	_~	_1.19s	_1.20s	_{p=0.405 n=6}
_{Check Time}	_{18.17s (± 0.22%)}	_{18.13s (± 0.49%)}	_~	_18.01s	_18.22s	_{p=0.685 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.53s (± 0.16%)}	_{22.46s (± 0.46%)}	_~	_22.34s	_22.58s	_{p=0.335 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-06-17T15:28:28Z

@sandersn Here are the results of running the top 400 repos with tsc comparing main and refs/pull/58864/merge:

Everything looks good!

sandersn · 2024-06-17T22:53:23Z

The only perf test diff is in the binder for mui-docs, which seems unrelated.

Deprecate .hasRestElement in favor of combinedFlags

a570791

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 14, 2024

Andarist mentioned this pull request Jun 14, 2024

Fixed reported errors for variadic element mismatches #58708

Merged

weswigham approved these changes Jun 14, 2024

View reviewed changes

weswigham requested review from ahejlsberg, jakebailey and sandersn June 14, 2024 20:19

Andarist added 2 commits June 14, 2024 23:11

Merge remote-tracking branch 'origin/main' into deprecate-has-rest-el…

4df53bc

…ement

fmt

a538f13

sandersn approved these changes Jun 17, 2024

View reviewed changes

sandersn self-assigned this Jun 17, 2024

sandersn merged commit 7410cfd into microsoft:main Jun 17, 2024

sandersn removed this from PR Backlog Apr 22, 2025

microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025

Deprecate .hasRestElement in favor of combinedFlags #58864

Deprecate .hasRestElement in favor of combinedFlags #58864

Uh oh!

Conversation

Andarist commented Jun 14, 2024

Uh oh!

typescript-bot commented Jun 14, 2024

Uh oh!

typescript-bot commented Jun 14, 2024

Uh oh!

weswigham left a comment

Choose a reason for hiding this comment

Uh oh!

jakebailey commented Jun 14, 2024

Uh oh!

sandersn commented Jun 17, 2024

Uh oh!

sandersn commented Jun 17, 2024

Uh oh!

typescript-bot commented Jun 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jun 17, 2024

Uh oh!

typescript-bot commented Jun 17, 2024

Uh oh!

typescript-bot commented Jun 17, 2024

tsc

Uh oh!

typescript-bot commented Jun 17, 2024

Uh oh!

sandersn commented Jun 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Deprecate `.hasRestElement` in favor of `combinedFlags` #58864

Deprecate `.hasRestElement` in favor of `combinedFlags` #58864

typescript-bot commented Jun 17, 2024 •

edited

Loading