Emit __esModule in when target == es6 #5907
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
I'm not sure this was supposed to be part of this PR (though it certainly seems correct!)
Contributor
Author
There was a problem hiding this comment.
can you add that then in your PR?
Member
There was a problem hiding this comment.
Can I just open a new PR for it? :3
Member
|
I think #5908 may be a better fix since it removes a bunch of redundant emitter logic, also I'm not sure we really need a test dedicated to this, since it manifests in every es6 module compliance test with a default export (which is many of them). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emits
__esModuleif target == ES6 and module != ES6. also add emitting __esModule to export default class, which we missed before.More details about this can be found in #5844 (comment)