Try synthesizing `never` props for missing keys in normalized object literals #59287

RyanCavanaugh · 2024-07-15T21:30:06Z

Candidate fix for #59180

…props

RyanCavanaugh · 2024-07-15T21:30:17Z

@typescript-bot test it
@typescript-bot pack this

typescript-bot · 2024-07-15T21:30:21Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-07-15T21:32:22Z

Hey @RyanCavanaugh, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/162748/artifacts?artifactName=tgz&fileId=D951FD8CE6429B6195027CC74D670D17C1AF05E0507ECC326C32D13DEB48906502&fileName=/typescript-5.6.0-insiders.20240715.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.6.0-pr-59287-2".;

typescript-bot · 2024-07-15T21:53:37Z

Hey @RyanCavanaugh, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: json-merge-patch
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/json-merge-patch/json-merge-patch-tests.ts
  14:5  error  TypeScript@local expected type to be:
  { a: string; b?: undefined; } | { b: string; a?: undefined; }
got:
  { a: string; b?: never; } | { b: string; a?: never; }                                                              @definitelytyped/expect
  26:5  error  TypeScript@local expected type to be:
  { a: string; b: string; } | { a: string; b?: undefined; }
got:
  { a: string; b: string; } | { a: string; b?: never; }                                                                  @definitelytyped/expect
  32:5  error  TypeScript@local expected type to be:
  { a: any; b?: undefined; } | { b: string; a?: undefined; }
got:
  { a: any; b?: never; } | { b: string; a?: never; }                                                                    @definitelytyped/expect
  62:5  error  TypeScript@local expected type to be:
  { a: { b: { c: string; }; }; d: string; } | { a: { b: string; }; d?: undefined; }
got:
  { a: { b: { c: string; }; }; d: string; } | { a: { b: string; }; d?: never; }                  @definitelytyped/expect
  68:5  error  TypeScript@local expected type to be:
  { a: { b: { c: string; }; d: string; }; } | { a: { b: { c: string; }; d?: undefined; }; }
got:
  { a: { b: { c: string; }; d: string; }; } | { a: { b: { c: string; }; d?: never; }; }  @definitelytyped/expect

✖ 5 problems (5 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.22_typescript@5.6.0-dev.20240715/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.22_typescript@5.6.0-dev.20240715/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: plotly.js
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/plotly.js/test/index-tests.ts
  63:20  error  TypeScript@local compile error: 
Conversion of type '{ mode: "markers"; x: (string | number)[]; y: (string | number)[]; text: (string | number)[]; marker: { size: (string | number)[]; sizemode: "area"; sizeref: number; pattern: { shape: "/"; }; }; type: "scatter"; transforms: ({ ...; } | ... 1 more ... | { ...; })[]; width: number; }' to type 'PlotData' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
  Type '{ mode: "markers"; x: (string | number)[]; y: (string | number)[]; text: (string | number)[]; marker: { size: (string | number)[]; sizemode: "area"; sizeref: number; pattern: { shape: "/"; }; }; type: "scatter"; transforms: ({ ...; } | ... 1 more ... | { ...; })[]; width: number; }' is missing the following properties from type 'PlotData': z, i, j, k, and 110 more  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.22_typescript@5.6.0-dev.20240715/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.22_typescript@5.6.0-dev.20240715/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

typescript-bot · 2024-07-15T22:06:23Z

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,403k (± 0.98%)}	_{192,916k (± 0.74%)}	_~	_192,133k	_195,789k	_{p=1.000 n=6}
_{Parse Time}	_{1.30s (± 0.63%)}	_{1.30s (± 0.69%)}	_~	_1.29s	_1.31s	_{p=0.550 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.47s (± 0.32%)}	_{9.45s (± 0.27%)}	_~	_9.41s	_9.49s	_{p=0.145 n=6}
_{Emit Time}	_{2.74s (± 0.36%)}	_{2.74s (± 0.67%)}	_~	_2.72s	_2.76s	_{p=0.935 n=6}
_{Total Time}	_{14.22s (± 0.23%)}	_{14.20s (± 0.21%)}	_~	_14.16s	_14.23s	_{p=0.123 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,120	_944,120	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,047	_407,047	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,405k (± 0.01%)}	_{1,218,351k (± 0.01%)}	_~	_1,218,256k	_1,218,454k	_{p=0.173 n=6}
_{Parse Time}	_{6.71s (± 0.29%)}	_{6.71s (± 0.42%)}	_~	_6.68s	_6.76s	_{p=0.745 n=6}
_{Bind Time}	_{1.86s (± 0.40%)}	_{1.87s (± 0.44%)}	_~	_1.85s	_1.87s	_{p=0.082 n=6}
_{Check Time}	_{30.63s (± 0.25%)}	_{30.61s (± 0.49%)}	_~	_30.44s	_30.87s	_{p=0.688 n=6}
_{Emit Time}	_{13.60s (± 0.25%)}	_{13.57s (± 0.87%)}	_~	_13.34s	_13.66s	_{p=0.871 n=6}
_{Total Time}	_{52.80s (± 0.18%)}	_{52.76s (± 0.35%)}	_~	_52.50s	_53.07s	_{p=0.470 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,249,830	_2,249,745	_{-85 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_937,437	_937,372	_{-65 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,165,019k (± 0.00%)}	_{2,165,113k (± 0.00%)}	_{+94k (+ 0.00%)}	_2,165,016k	_2,165,157k	_{p=0.030 n=6}
_{Parse Time}	_{7.84s (± 0.22%)}	_{7.84s (± 0.32%)}	_~	_7.81s	_7.87s	_{p=0.505 n=6}
_{Bind Time}	_{2.76s (± 0.62%)}	_{2.76s (± 0.54%)}	_~	_2.74s	_2.78s	_{p=0.682 n=6}
_{Check Time}	_{84.82s (± 0.44%)}	_{84.63s (± 0.45%)}	_~	_84.15s	_85.25s	_{p=0.378 n=6}
_{Emit Time}	_{0.17s (± 3.32%)}	_{0.17s (± 4.47%)}	_~	_0.16s	_0.18s	_{p=0.476 n=6}
_{Total Time}	_{95.59s (± 0.38%)}	_{95.40s (± 0.41%)}	_~	_94.90s	_96.05s	_{p=0.298 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,063	_1,226,062	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,603	_261,602	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,338,719k (± 0.01%)}	_{2,338,565k (± 0.02%)}	_~	_2,338,103k	_2,339,196k	_{p=0.378 n=6}
_{Parse Time}	_{5.10s (± 0.81%)}	_{5.07s (± 0.84%)}	_~	_5.02s	_5.13s	_{p=0.297 n=6}
_{Bind Time}	_{1.90s (± 0.52%)}	_{1.90s (± 1.04%)}	_~	_1.88s	_1.92s	_{p=0.624 n=6}
_{Check Time}	_{34.05s (± 0.43%)}	_{34.03s (± 0.26%)}	_~	_33.95s	_34.18s	_{p=0.810 n=6}
_{Emit Time}	_{3.23s (± 0.71%)}	_{3.27s (± 2.18%)}	_~	_3.19s	_3.40s	_{p=0.261 n=6}
_{Total Time}	_{44.30s (± 0.41%)}	_{44.28s (± 0.21%)}	_~	_44.16s	_44.43s	_{p=0.688 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,063	_1,226,062	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,603	_261,602	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,413,369k (± 0.01%)}	_{2,413,086k (± 0.02%)}	_~	_2,412,514k	_2,413,682k	_{p=0.471 n=6}
_{Parse Time}	_{6.29s (± 0.51%)}	_{6.34s (± 0.60%)}	_{+0.05s (+ 0.82%)}	_6.30s	_6.39s	_{p=0.045 n=6}
_{Bind Time}	_{2.03s (± 1.72%)}	_{2.02s (± 1.20%)}	_~	_2.00s	_2.06s	_{p=0.809 n=6}
_{Check Time}	_{40.58s (± 0.23%)}	_{40.49s (± 0.24%)}	_~	_40.35s	_40.65s	_{p=0.173 n=6}
_{Emit Time}	_{3.92s (± 0.53%)}	_{3.89s (± 1.63%)}	_~	_3.82s	_4.01s	_{p=0.128 n=6}
_{Total Time}	_{52.80s (± 0.12%)}	_{52.72s (± 0.22%)}	_~	_52.51s	_52.84s	_{p=0.230 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,307	_258,307	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,794	_104,794	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{427,161k (± 0.04%)}	_{427,115k (± 0.01%)}	_~	_427,056k	_427,170k	_{p=0.810 n=6}
_{Parse Time}	_{4.11s (± 0.13%)}	_{4.11s (± 0.73%)}	_~	_4.08s	_4.15s	_{p=0.934 n=6}
_{Bind Time}	_{1.63s (± 0.90%)}	_{1.62s (± 0.99%)}	_~	_1.59s	_1.63s	_{p=0.802 n=6}
_{Check Time}	_{22.06s (± 0.39%)}	_{22.04s (± 0.16%)}	_~	_21.99s	_22.09s	_{p=0.936 n=6}
_{Emit Time}	_{2.01s (± 1.24%)}	_{2.02s (± 1.15%)}	_~	_1.99s	_2.06s	_{p=0.373 n=6}
_{Total Time}	_{29.80s (± 0.29%)}	_{29.80s (± 0.12%)}	_~	_29.75s	_29.85s	_{p=0.747 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,568k (± 0.04%)}	_{369,635k (± 0.03%)}	_~	_369,436k	_369,801k	_{p=0.298 n=6}
_{Parse Time}	_{3.43s (± 1.52%)}	_{3.43s (± 0.72%)}	_~	_3.39s	_3.46s	_{p=1.000 n=6}
_{Bind Time}	_{1.94s (± 0.39%)}	_{1.94s (± 0.39%)}	_~	_1.93s	_1.95s	_{p=1.000 n=6}
_{Check Time}	_{19.16s (± 0.26%)}	_{19.09s (± 0.39%)}	_~	_18.96s	_19.15s	_{p=0.106 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.52s (± 0.36%)}	_{24.46s (± 0.28%)}	_~	_24.35s	_24.55s	_{p=0.228 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,891,299	_2,891,230	_{-69 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_978,316	_978,270	_{-46 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,055,158k (± 0.00%)}	_{3,055,140k (± 0.00%)}	_~	_3,055,105k	_3,055,236k	_{p=0.810 n=6}
_{Parse Time}	_{13.66s (± 0.36%)}	_{13.65s (± 0.35%)}	_~	_13.59s	_13.71s	_{p=0.747 n=6}
_{Bind Time}	_{4.18s (± 0.39%)}	_{4.18s (± 0.25%)}	_~	_4.16s	_4.19s	_{p=0.802 n=6}
_{Check Time}	_{73.36s (± 0.68%)}	_{73.12s (± 0.28%)}	_~	_72.88s	_73.38s	_{p=0.748 n=6}
_{Emit Time}	_{23.61s (± 0.81%)}	_{23.60s (± 0.39%)}	_~	_23.43s	_23.68s	_{p=0.521 n=6}
_{Total Time}	_{114.81s (± 0.31%)}	_{114.55s (± 0.27%)}	_~	_114.24s	_114.92s	_{p=0.229 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,280	_267,280	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,834	_108,834	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,845k (± 0.03%)}	_{411,796k (± 0.03%)}	_~	_411,722k	_411,992k	_{p=0.378 n=6}
_{Parse Time}	_{4.77s (± 0.31%)}	_{4.74s (± 0.39%)}	_{-0.03s (- 0.59%)}	_4.72s	_4.77s	_{p=0.032 n=6}
_{Bind Time}	_{2.09s (± 0.49%)}	_{2.09s (± 0.63%)}	_~	_2.08s	_2.11s	_{p=0.929 n=6}
_{Check Time}	_{20.80s (± 0.82%)}	_{20.68s (± 0.41%)}	_~	_20.57s	_20.80s	_{p=0.128 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.66s (± 0.64%)}	_{27.52s (± 0.27%)}	_~	_27.41s	_27.60s	_{p=0.066 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_510,479	_510,479	_~	_~	_~	_{p=1.000 n=6}
_Types	_161,598	_161,597	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{448,148k (± 0.04%)}	_{448,161k (± 0.07%)}	_~	_447,609k	_448,559k	_{p=0.575 n=6}
_{Parse Time}	_{3.90s (± 0.52%)}	_{3.90s (± 0.56%)}	_~	_3.87s	_3.93s	_{p=0.568 n=6}
_{Bind Time}	_{1.46s (± 0.80%)}	_{1.45s (± 0.52%)}	_~	_1.44s	_1.46s	_{p=0.383 n=6}
_{Check Time}	_{21.10s (± 0.37%)}	_{21.14s (± 0.47%)}	_~	_20.98s	_21.27s	_{p=0.423 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{26.46s (± 0.34%)}	_{26.48s (± 0.38%)}	_~	_26.31s	_26.59s	_{p=0.377 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-07-15T22:13:26Z

@RyanCavanaugh Here are the results of running the user tests with tsc comparing main and refs/pull/59287/merge:

Everything looks good!

typescript-bot · 2024-07-15T23:31:37Z

@RyanCavanaugh Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59287/merge:

Something interesting changed - please have a look.

Details

ag-grid/ag-grid

31 of 110 projects failed to build with the old tsc and were ignored

heyxyz/hey

1 of 14 projects failed to build with the old tsc and were ignored

apps/web/tsconfig.json

error TS2677: A type predicate's type must be assignable to its parameter's type.
- apps/web/src/components/Home/FeedType.tsx#L43
error TS2339: Property 'type' does not exist on type 'false | { name: string; track: string; type: HomeFeedType; badge?: never; } | { badge: Element; name: string; track: string; type: HomeFeedType; }'.
error TS2339: Property 'badge' does not exist on type 'false | { name: string; track: string; type: HomeFeedType; badge?: never; } | { badge: Element; name: string; track: string; type: HomeFeedType; }'.
- apps/web/src/components/Home/FeedType.tsx#L56
error TS2339: Property 'name' does not exist on type 'false | { name: string; track: string; type: HomeFeedType; badge?: never; } | { badge: Element; name: string; track: string; type: HomeFeedType; }'.
- apps/web/src/components/Home/FeedType.tsx#L58
error TS2339: Property 'track' does not exist on type 'false | { name: string; track: string; type: HomeFeedType; badge?: never; } | { badge: Element; name: string; track: string; type: HomeFeedType; }'.
- apps/web/src/components/Home/FeedType.tsx#L61

jhipster/generator-jhipster

tsconfig.types.json

error TS2790: The operand of a 'delete' operator must be optional.
- jdl/parsing/lexer/option-tokens.ts#L47

tsconfig.spec.json

error TS2578: Unused '@ts-expect-error' directive.
- jdl/converters/parsed-jdl-to-jdl-object/relationship-converter.spec.ts#L59
- jdl/converters/parsed-jdl-to-jdl-object/relationship-converter.spec.ts#L120
error TS2790: The operand of a 'delete' operator must be optional.
- jdl/parsing/lexer/option-tokens.ts#L47

tsconfig.json

error TS2790: The operand of a 'delete' operator must be optional.
- jdl/parsing/lexer/option-tokens.ts#L47

labring/FastGPT

1 of 8 projects failed to build with the old tsc and were ignored

projects/app/tsconfig.json

error TS2322: Type 'OAuthEnum | LoginPageTypeEnum' is not assignable to type '"github" | "google" | "wechat"'.
- projects/app/src/pages/login/components/LoginForm/components/FormLayout.tsx#L117

RyanCavanaugh · 2024-07-16T16:33:34Z

FastGPT break is likely indicative of the others, where in this example

const obj = Math.random() > 0.5 ? { b: "hello" } : { a: "ok", b: 42 };
if (obj.a) {
  let n: number = obj.b;
}

we no longer consider a: "ok" | a?: never to be a discriminant on obj

RyanCavanaugh added 2 commits July 10, 2024 13:08

Pre-fix baseline

5534cca

Produce { x?: never } instead of { x?: undefined } in normalized obj …

7e2e4a9

…props

typescript-bot assigned RyanCavanaugh Jul 15, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 15, 2024

RyanCavanaugh closed this Jul 16, 2024

microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025

Try synthesizing never props for missing keys in normalized object literals #59287

Try synthesizing never props for missing keys in normalized object literals #59287

Uh oh!

Conversation

RyanCavanaugh commented Jul 15, 2024

Uh oh!

RyanCavanaugh commented Jul 15, 2024

Uh oh!

typescript-bot commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 15, 2024

Uh oh!

typescript-bot commented Jul 15, 2024

tsc

Uh oh!

typescript-bot commented Jul 15, 2024

Uh oh!

typescript-bot commented Jul 15, 2024

Uh oh!

RyanCavanaugh commented Jul 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Try synthesizing `never` props for missing keys in normalized object literals #59287

Try synthesizing `never` props for missing keys in normalized object literals #59287

typescript-bot commented Jul 15, 2024 •

edited

Loading

typescript-bot commented Jul 15, 2024 •

edited

Loading