Fixes #58268 - Improve Tuple Type Handling and Address Circular References#60584
Open
RyanMyrvold wants to merge 2 commits intomicrosoft:mainfrom
Open
Fixes #58268 - Improve Tuple Type Handling and Address Circular References#60584RyanMyrvold wants to merge 2 commits intomicrosoft:mainfrom
RyanMyrvold wants to merge 2 commits intomicrosoft:mainfrom
Conversation
…iled logging. - Corrected the handling of tuple types in `getTupleElementTypes`: - Implemented proper checks for resolved type arguments and element flags. - Ensured accurate identification of tuple types using `isTupleType`. - Added a guard against circular references by using a `Set` to track seen types. - Enhanced debugging by adding detailed console logs: - Logs the type being analyzed. - Warns when a circular reference is detected. - Logs when a tuple type is detected and when resolved type arguments are found. - Indicates when a type is not a tuple.
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
typescript-bot
added
For Milestone Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58268
What was fixed:
The compiler was failing with stack overflows or complexity errors when processing certain tuple types, particularly deeply nested or concatenated tuples.
Solution:
We refactored how tuple element types are extracted to handle recursive and complex structures more robustly. A new function,
getTupleElementTypes, was added to:resolvedTypeArgumentswhen available.This ensures tuple-related operations no longer result in stack overflows and handle complexity gracefully.