Skip to content

lib.es2017: Move SharedArrayBuffer[Symbol.species] onto constructor interface #61271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

lib.es2017: Move SharedArrayBuffer[Symbol.species] onto constructor interface #61271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/es2017.sharedmemory.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ interface SharedArrayBuffer {
* Returns a section of an SharedArrayBuffer.
*/
slice(begin?: number, end?: number): SharedArrayBuffer;
readonly [Symbol.species]: SharedArrayBuffer;
readonly [Symbol.toStringTag]: "SharedArrayBuffer";
}

interface SharedArrayBufferConstructor {
readonly prototype: SharedArrayBuffer;
new (byteLength?: number): SharedArrayBuffer;
readonly [Symbol.species]: SharedArrayBufferConstructor;
}
declare var SharedArrayBuffer: SharedArrayBufferConstructor;

Expand Down
6 changes: 3 additions & 3 deletions tests/baselines/reference/useSharedArrayBuffer4.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
//// [useSharedArrayBuffer4.ts]
var foge = new SharedArrayBuffer(1024);
var bar = foge.slice(1, 10);
var species = foge[Symbol.species];
var stringTag = foge[Symbol.toStringTag];
var len = foge.byteLength;
var len = foge.byteLength;
var species = SharedArrayBuffer[Symbol.species];

//// [useSharedArrayBuffer4.js]
var foge = new SharedArrayBuffer(1024);
var bar = foge.slice(1, 10);
var species = foge[Symbol.species];
var stringTag = foge[Symbol.toStringTag];
var len = foge.byteLength;
var species = SharedArrayBuffer[Symbol.species];
18 changes: 9 additions & 9 deletions tests/baselines/reference/useSharedArrayBuffer4.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,23 +11,23 @@ var bar = foge.slice(1, 10);
>foge : Symbol(foge, Decl(useSharedArrayBuffer4.ts, 0, 3))
>slice : Symbol(SharedArrayBuffer.slice, Decl(lib.es2017.sharedmemory.d.ts, --, --))

var species = foge[Symbol.species];
>species : Symbol(species, Decl(useSharedArrayBuffer4.ts, 2, 3))
>foge : Symbol(foge, Decl(useSharedArrayBuffer4.ts, 0, 3))
>Symbol.species : Symbol(SymbolConstructor.species, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
>Symbol : Symbol(Symbol, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.symbol.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
>species : Symbol(SymbolConstructor.species, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))

var stringTag = foge[Symbol.toStringTag];
>stringTag : Symbol(stringTag, Decl(useSharedArrayBuffer4.ts, 3, 3))
>stringTag : Symbol(stringTag, Decl(useSharedArrayBuffer4.ts, 2, 3))
>foge : Symbol(foge, Decl(useSharedArrayBuffer4.ts, 0, 3))
>Symbol.toStringTag : Symbol(SymbolConstructor.toStringTag, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
>Symbol : Symbol(Symbol, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.symbol.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
>toStringTag : Symbol(SymbolConstructor.toStringTag, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))

var len = foge.byteLength;
>len : Symbol(len, Decl(useSharedArrayBuffer4.ts, 4, 3))
>len : Symbol(len, Decl(useSharedArrayBuffer4.ts, 3, 3))
>foge.byteLength : Symbol(SharedArrayBuffer.byteLength, Decl(lib.es2017.sharedmemory.d.ts, --, --))
>foge : Symbol(foge, Decl(useSharedArrayBuffer4.ts, 0, 3))
>byteLength : Symbol(SharedArrayBuffer.byteLength, Decl(lib.es2017.sharedmemory.d.ts, --, --))

var species = SharedArrayBuffer[Symbol.species];
>species : Symbol(species, Decl(useSharedArrayBuffer4.ts, 4, 3))
>SharedArrayBuffer : Symbol(SharedArrayBuffer, Decl(lib.es2017.sharedmemory.d.ts, --, --), Decl(lib.es2017.sharedmemory.d.ts, --, --))
>Symbol.species : Symbol(SymbolConstructor.species, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
>Symbol : Symbol(Symbol, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.symbol.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
>species : Symbol(SymbolConstructor.species, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))

28 changes: 14 additions & 14 deletions tests/baselines/reference/useSharedArrayBuffer4.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,20 +27,6 @@ var bar = foge.slice(1, 10);
>10 : 10
> : ^^

var species = foge[Symbol.species];
>species : SharedArrayBuffer
> : ^^^^^^^^^^^^^^^^^
>foge[Symbol.species] : SharedArrayBuffer
> : ^^^^^^^^^^^^^^^^^
>foge : SharedArrayBuffer
> : ^^^^^^^^^^^^^^^^^
>Symbol.species : unique symbol
> : ^^^^^^^^^^^^^
>Symbol : SymbolConstructor
> : ^^^^^^^^^^^^^^^^^
>species : unique symbol
> : ^^^^^^^^^^^^^

var stringTag = foge[Symbol.toStringTag];
>stringTag : "SharedArrayBuffer"
> : ^^^^^^^^^^^^^^^^^^^
Expand All @@ -65,3 +51,17 @@ var len = foge.byteLength;
>byteLength : number
> : ^^^^^^

var species = SharedArrayBuffer[Symbol.species];
>species : SharedArrayBufferConstructor
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>SharedArrayBuffer[Symbol.species] : SharedArrayBufferConstructor
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>SharedArrayBuffer : SharedArrayBufferConstructor
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>Symbol.species : unique symbol
> : ^^^^^^^^^^^^^
>Symbol : SymbolConstructor
> : ^^^^^^^^^^^^^^^^^
>species : unique symbol
> : ^^^^^^^^^^^^^

6 changes: 3 additions & 3 deletions tests/baselines/reference/useSharedArrayBuffer5.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

//// [useSharedArrayBuffer5.ts]
var foge = new SharedArrayBuffer(1024);
var species = foge[Symbol.species];
var stringTag = foge[Symbol.toStringTag];
var stringTag = foge[Symbol.toStringTag];
var species = SharedArrayBuffer[Symbol.species];

//// [useSharedArrayBuffer5.js]
var foge = new SharedArrayBuffer(1024);
var species = foge[Symbol.species];
var stringTag = foge[Symbol.toStringTag];
var species = SharedArrayBuffer[Symbol.species];
16 changes: 8 additions & 8 deletions tests/baselines/reference/useSharedArrayBuffer5.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,17 @@ var foge = new SharedArrayBuffer(1024);
>foge : Symbol(foge, Decl(useSharedArrayBuffer5.ts, 0, 3))
>SharedArrayBuffer : Symbol(SharedArrayBuffer, Decl(lib.es2017.sharedmemory.d.ts, --, --), Decl(lib.es2017.sharedmemory.d.ts, --, --))

var species = foge[Symbol.species];
>species : Symbol(species, Decl(useSharedArrayBuffer5.ts, 1, 3))
>foge : Symbol(foge, Decl(useSharedArrayBuffer5.ts, 0, 3))
>Symbol.species : Symbol(SymbolConstructor.species, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
>Symbol : Symbol(Symbol, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.symbol.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
>species : Symbol(SymbolConstructor.species, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))

var stringTag = foge[Symbol.toStringTag];
>stringTag : Symbol(stringTag, Decl(useSharedArrayBuffer5.ts, 2, 3))
>stringTag : Symbol(stringTag, Decl(useSharedArrayBuffer5.ts, 1, 3))
>foge : Symbol(foge, Decl(useSharedArrayBuffer5.ts, 0, 3))
>Symbol.toStringTag : Symbol(SymbolConstructor.toStringTag, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
>Symbol : Symbol(Symbol, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.symbol.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
>toStringTag : Symbol(SymbolConstructor.toStringTag, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))

var species = SharedArrayBuffer[Symbol.species];
>species : Symbol(species, Decl(useSharedArrayBuffer5.ts, 2, 3))
>SharedArrayBuffer : Symbol(SharedArrayBuffer, Decl(lib.es2017.sharedmemory.d.ts, --, --), Decl(lib.es2017.sharedmemory.d.ts, --, --))
>Symbol.species : Symbol(SymbolConstructor.species, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
>Symbol : Symbol(Symbol, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.symbol.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
>species : Symbol(SymbolConstructor.species, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))

28 changes: 14 additions & 14 deletions tests/baselines/reference/useSharedArrayBuffer5.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,6 @@ var foge = new SharedArrayBuffer(1024);
>1024 : 1024
> : ^^^^

var species = foge[Symbol.species];
>species : SharedArrayBuffer
> : ^^^^^^^^^^^^^^^^^
>foge[Symbol.species] : SharedArrayBuffer
> : ^^^^^^^^^^^^^^^^^
>foge : SharedArrayBuffer
> : ^^^^^^^^^^^^^^^^^
>Symbol.species : unique symbol
> : ^^^^^^^^^^^^^
>Symbol : SymbolConstructor
> : ^^^^^^^^^^^^^^^^^
>species : unique symbol
> : ^^^^^^^^^^^^^

var stringTag = foge[Symbol.toStringTag];
>stringTag : "SharedArrayBuffer"
> : ^^^^^^^^^^^^^^^^^^^
Expand All @@ -39,3 +25,17 @@ var stringTag = foge[Symbol.toStringTag];
>toStringTag : unique symbol
> : ^^^^^^^^^^^^^

var species = SharedArrayBuffer[Symbol.species];
>species : SharedArrayBufferConstructor
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>SharedArrayBuffer[Symbol.species] : SharedArrayBufferConstructor
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>SharedArrayBuffer : SharedArrayBufferConstructor
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>Symbol.species : unique symbol
> : ^^^^^^^^^^^^^
>Symbol : SymbolConstructor
> : ^^^^^^^^^^^^^^^^^
>species : unique symbol
> : ^^^^^^^^^^^^^

4 changes: 2 additions & 2 deletions tests/cases/conformance/es2017/useSharedArrayBuffer4.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@

var foge = new SharedArrayBuffer(1024);
var bar = foge.slice(1, 10);
var species = foge[Symbol.species];
var stringTag = foge[Symbol.toStringTag];
var len = foge.byteLength;
var len = foge.byteLength;
var species = SharedArrayBuffer[Symbol.species];
4 changes: 2 additions & 2 deletions tests/cases/conformance/es2017/useSharedArrayBuffer5.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
// @lib: es6,es2017.sharedmemory

var foge = new SharedArrayBuffer(1024);
var species = foge[Symbol.species];
var stringTag = foge[Symbol.toStringTag];
var stringTag = foge[Symbol.toStringTag];
var species = SharedArrayBuffer[Symbol.species];