Skip to content

Test out adding toStringTag to DOM #62682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+928 −44
Draft

Test out adding toStringTag to DOM #62682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
814744b
add toStringTag
jakebailey Oct 28, 2025
58e4a65
Update baselines
jakebailey Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
665 changes: 665 additions & 0 deletions src/lib/dom.generated.d.ts
View file
Open in desktop

Large diffs are not rendered by default.

222 changes: 222 additions & 0 deletions src/lib/webworker.generated.d.ts
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion tests/baselines/reference/callsOnComplexSignatures.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Assignability cache: 2,500
Type Count: 10,000
Instantiation count: 100,000
Symbol count: 50,000
Symbol count: 100,000

=== callsOnComplexSignatures.tsx ===
/// <reference path="react16.d.ts" />
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/jsxCallElaborationCheckNoCrash1.errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
jsxCallElaborationCheckNoCrash1.tsx(10,29): error TS2322: Type '{}' is not assignable to type 'LibraryManagedAttributes<Tag, DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>>'.
jsxCallElaborationCheckNoCrash1.tsx(10,29): error TS2322: Type '{}' is not assignable to type 'LibraryManagedAttributes<Tag, ClassAttributes<HTMLDivElement> & HTMLAttributes<HTMLDivElement> & ClassAttributes<HTMLSpanElement> & HTMLAttributes<HTMLSpanElement>>'.


==== jsxCallElaborationCheckNoCrash1.tsx (1 errors) ====
Expand All @@ -13,7 +13,7 @@ jsxCallElaborationCheckNoCrash1.tsx(10,29): error TS2322: Type '{}' is not assig
): React.SFC => {
const Component = () => <TagElement />;
~~~~~~~~~~
!!! error TS2322: Type '{}' is not assignable to type 'LibraryManagedAttributes<Tag, DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>>'.
!!! error TS2322: Type '{}' is not assignable to type 'LibraryManagedAttributes<Tag, ClassAttributes<HTMLDivElement> & HTMLAttributes<HTMLDivElement> & ClassAttributes<HTMLSpanElement> & HTMLAttributes<HTMLSpanElement>>'.
return Component;
};

2 changes: 1 addition & 1 deletion tests/baselines/reference/jsxCallElaborationCheckNoCrash1.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Assignability cache: 5,000
Type Count: 10,000
Instantiation count: 50,000
Symbol count: 50,000
Symbol count: 100,000

=== jsxCallElaborationCheckNoCrash1.tsx ===
/// <reference path="react16.d.ts" />
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/jsxIntrinsicElementsCompatability.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Assignability cache: 2,500
Type Count: 10,000
Instantiation count: 100,000
Symbol count: 50,000
Symbol count: 100,000

=== jsxIntrinsicElementsCompatability.tsx ===
/// <reference path="react16.d.ts" />
Expand Down
24 changes: 12 additions & 12 deletions tests/baselines/reference/mappedTypeRecursiveInference.errors.txt
View file
Open in desktop

Large diffs are not rendered by default.

40 changes: 20 additions & 20 deletions tests/baselines/reference/mappedTypeRecursiveInference.types
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions tests/baselines/reference/reactDefaultPropsInferenceSuccess.types
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
//// [tests/cases/compiler/reactDefaultPropsInferenceSuccess.tsx] ////

=== Performance Stats ===
Assignability cache: 5,000
Assignability cache: 2,500
Type Count: 10,000
Instantiation count: 100,000
Symbol count: 50,000
Symbol count: 100,000

=== reactDefaultPropsInferenceSuccess.tsx ===
/// <reference path="react16.d.ts" />
Expand Down
3 changes: 0 additions & 3 deletions tests/baselines/reference/recursiveTypeReferences1.types
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
//// [tests/cases/conformance/types/typeRelationships/recursiveTypes/recursiveTypeReferences1.ts] ////

=== Performance Stats ===
Type Count: 1,000

=== recursiveTypeReferences1.ts ===
type ValueOrArray<T> = T | Array<ValueOrArray<T>>;
>ValueOrArray : ValueOrArray<T>
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/tsxReactPropsInferenceSucceedsOnIntersections.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Assignability cache: 2,500
Type Count: 10,000
Instantiation count: 100,000
Symbol count: 50,000
Symbol count: 100,000

=== tsxReactPropsInferenceSucceedsOnIntersections.tsx ===
/// <reference path="react16.d.ts" />
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/verifyDefaultLib_webworker.types
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//// [tests/cases/compiler/verifyDefaultLib_webworker.ts] ////

=== Performance Stats ===
Type Count: 5,000
Type Count: 10,000
Instantiation count: 2,500

=== verifyDefaultLib_webworker.ts ===
Expand Down