Skip to content

ES2020: fix String.prototype.matchAll type and description #62873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 1 commit into from
Dec 11, 2025
+7 −7
Merged

ES2020: fix String.prototype.matchAll type and description #62873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/lib/es2020.string.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@

interface String {
/**
* Matches a string with a regular expression, and returns an iterable of matches
* Matches a string with a regular expression or string, and returns an iterable of matches
* containing the results of that search.
* @param regexp A variable name or string literal containing the regular expression pattern and flags.
* @param regexp A regular expression or string literal with which to search the string
*/
matchAll(regexp: RegExp): RegExpStringIterator<RegExpExecArray>;
matchAll(regexp: RegExp | string): RegExpStringIterator<RegExpExecArray>;

/** Converts all alphabetic characters to lowercase, taking into account the host environment's current locale. */
toLocaleLowerCase(locales?: Intl.LocalesArgument): string;
Expand Down
8 changes: 4 additions & 4 deletions tests/baselines/reference/stringMatchAll.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ const matches = "matchAll".matchAll(/\w/g);
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>"matchAll".matchAll(/\w/g) : RegExpStringIterator<RegExpExecArray>
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>"matchAll".matchAll : (regexp: RegExp) => RegExpStringIterator<RegExpExecArray>
> : ^ ^^ ^^^^^
>"matchAll".matchAll : (regexp: RegExp | string) => RegExpStringIterator<RegExpExecArray>
> : ^ ^^ ^^^^^
>"matchAll" : "matchAll"
> : ^^^^^^^^^^
>matchAll : (regexp: RegExp) => RegExpStringIterator<RegExpExecArray>
> : ^ ^^ ^^^^^
>matchAll : (regexp: RegExp | string) => RegExpStringIterator<RegExpExecArray>
> : ^ ^^ ^^^^^
>/\w/g : RegExp
> : ^^^^^^

Expand Down