Revert "ES2020: fix String.prototype.matchAll type and description" #62885
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
requested review from
DanielRosenwasser,
RyanCavanaugh and
Copilot
typescript-bot
added
Author: Team
For Uncommitted Bug
RyanCavanaugh
approved these changes
Dec 11, 2025
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous change that modified the String.prototype.matchAll type signature. The revert restores the original behavior where matchAll only accepts RegExp parameter instead of RegExp | string, aligning with TypeScript's strictness policy on similar methods.
- Reverts the type signature of
String.prototype.matchAllfrom acceptingRegExp | stringback to onlyRegExp - Updates JSDoc description to reflect the reverted parameter type
- Updates test baseline to match the reverted type signature
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib/es2020.string.d.ts | Reverts matchAll parameter type from RegExp | string to RegExp and updates JSDoc |
| tests/baselines/reference/stringMatchAll.types | Updates type baseline to reflect reverted matchAll signature |
Member
Author
|
for posterity for other readers, see thread at #62873 (comment) |
RyanCavanaugh
approved these changes
Dec 11, 2025
RyanCavanaugh
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #62873
It did not fix the linked issue, but instead actually "fixed" #47310, which is marked as working-as-intended for the same reason as why we ban other params for strictness' sake.