Skip to content

Port Salsa fixes #6905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 4, 2016
Merged

Port Salsa fixes #6905

merged 13 commits into from
Feb 4, 2016

Conversation

@billti
Copy link
Member

@billti billti commented Feb 4, 2016

Port Salsa fixes for #6679, #6699, #6680, #6698, #6707, #6709, and #6741

@RyanCavanaugh @billti
Allow multiple 'this' property assignments in Salsa
5de87e3 
Fixes issue #6645

(cherry picked from commit 7259b9f)
@RyanCavanaugh @billti
Treat multiple prototype property assignments as union property decla…
671d83e 
…rations

(cherry picked from commit a4c6f66)
@RyanCavanaugh @billti
Use union types in the return type of functions in the error case
de2ef72 
Fixes #6663

(cherry picked from commit da6e82f)
@RyanCavanaugh @billti
Parse JSDoc comments for ES6 class constructors and methods
eb27166 
Fixes #6646

(cherry picked from commit 1b282cd)
@RyanCavanaugh @billti
Add some tests
176baf9 
(cherry picked from commit 3dfd378)
@RyanCavanaugh @billti
Recognize the RHS of assignments as the JSDoc target expression
96ec9be 
Fixes #6552

(cherry picked from commit 364b088)
@RyanCavanaugh @billti
Don't show the currently-completing thing at the cursor in JS files
f84bbcd 
Fixes #6693

(cherry picked from commit 124bd51)
@RyanCavanaugh @billti
Fix case when position === 0
c6e18a9 
(cherry picked from commit 1231c9e)
@RyanCavanaugh @billti
Don't crash when return type jsdoc tag is malformed
f0e70cb 
Fixes #6662

(cherry picked from commit 5a845bf)
@RyanCavanaugh @billti
Add explicit return undefined;
cf0e79a 
(cherry picked from commit 1f503f1)
@RyanCavanaugh @billti
Fix lint
a426de3 
(cherry picked from commit 9519688)
@RyanCavanaugh @billti
Add malformed parameter test
54bc98b 
(cherry picked from commit b15ff81)
@RyanCavanaugh @billti
Fixes bug #6673
73a8ace 
#6673

(cherry picked from commit f89ebb8)
@RyanCavanaugh
Copy link
Member

RyanCavanaugh commented Feb 4, 2016

👍

billti added a commit that referenced this pull request Feb 4, 2016
@billti
Merge pull request #6905 from Microsoft/portJsDocFixes
b761096 
Port Salsa fixes
@billti billti merged commit b761096 into release-1.8 Feb 4, 2016
@billti billti deleted the portJsDocFixes branch February 4, 2016 20:40
@mhegazy
Copy link
Contributor

mhegazy commented Feb 4, 2016

👍

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@billti @RyanCavanaugh @mhegazy @msftclas