Fix emitting super-call when using prologue directives #6911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielRosenwasser
changed the title
DanielRosenwasser
changed the title
| * @param ctor constructor declaration | ||
| * @param index an index to constructor's body to check | ||
| */ | ||
| function getSuperCallAtGivenIndex(ctor: ConstructorDeclaration, index: number): ExpressionStatement { |
Member
There was a problem hiding this comment.
I'd just take a NodeArray<Statement>
Member
There was a problem hiding this comment.
Can you add an explicit return at the end?
Member
There was a problem hiding this comment.
Why doesn't this just return a boolean if there's a super call at that index?
Contributor
Author
There was a problem hiding this comment.
We can't just return boolean because we should the super-call found here for emitting later
Member
|
Is it guaranteed that the initial super call will be an expression statement? Is it not possible to have the following? 1 && super() |
Contributor
|
yes, otherwise we error. we only skip prologues (e.g. "use strict"). |
Contributor
|
👍 |
Contributor
|
please port to master as well. |
Contributor
Author
|
@DanielRosenwasser yep it will an error. There is a discussion/issue whether we should allow that :) #6908 |
yuit
added a commit
that referenced
this pull request
Feb 5, 2016
Fix emitting super-call when using prologue directives
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6901