Fix go to definition

[YuichiNukiyama]

When Both the var and the interface , go to definition isn't work.
To resolve this issue, if variabe declaration was found, only it added to declaration array.

Fixes #1932

[RyanCavanaugh]

CI build failing due to linter errors on bad whitespace

[DanielRosenwasser]

tryAddDeclarationsWithSignatures

[YuichiNukiyama]

Did it.

[mhegazy]

i do not think this is the correct fix. this function tries to get you on the implementation signature or the last one if no implementation was found. this is special to signatures, this issue is about filtering the declaration location based on the reference location kind. i.e.:

var foo;   // value
type foo = any;  // type
namespace foo {} // namespace

+foo; // should only see the value (i.e var foo;)

var x: foo; // should only see the type (i.e type foo = any;)

foo.blah; // should see both namespace and value (i.e var foo, and namespace foo).

what we need to do is filter the declarations based on the reference node.

we have two functions that do that already, 1. getMeaningFromLocation see https://github.com/Microsoft/TypeScript/blob/master/src/services/services.ts#L6497, this tells you which one of value, type, or namespace the reference node is, and 2. getMeaningFromDeclaration see https://github.com/Microsoft/TypeScript/blob/master/src/services/services.ts#L6368, this tells you what is the meaning of a declaration.
the declaration location we add should be the ones the match:
symbol.declarations.filter(d => getMeaningFromDeclaration(d) & getMeaningFromLocation(node) !== 0)

[YuichiNukiyama]

@mhegazy Thank you for your advise. I try to fix it.

[RyanCavanaugh]

👍

[mhegazy]

why not just put this in the main loop in getDefinitionFromSymbol:

            if (!tryAddConstructSignature(symbol, node, symbolKind, symbolName, containerName, result) &&
                 !tryAddCallSignature(symbol, node, symbolKind, symbolName, containerName, result)) {
                 // Just add all the declarations.
                 const searcMeaning = getMeaningFromLocation(node);
                 forEach(declarations, declaration => {
                     if (getMeaningFromDeclaration(declaration) & searcMeaning) {
                         result.push(createDefinitionInfo(declaration, symbolKind, symbolName, containerName));
                     }
                 });
             }

[YuichiNukiyama]

If I checked types in the main loop, following tests were failed.
And I think shouldn't change these tests.

• goToTypeDefinition2.ts
• goToTypeAliases.ts
• goToTypeDefinitionUnionType.ts

[YuichiNukiyama]

This PR is too old. I close this one.