fix the issue that @property types are not recoganized#9621
Merged
zhengbli merged 2 commits intomicrosoft:masterfrom Jul 13, 2016
Merged
fix the issue that @property types are not recoganized#9621zhengbli merged 2 commits intomicrosoft:masterfrom
zhengbli merged 2 commits intomicrosoft:masterfrom
Conversation
src/compiler/checker.ts
Outdated
| if (declaration.kind === SyntaxKind.ExportAssignment) { | ||
| return links.type = checkExpression((<ExportAssignment>declaration).expression); | ||
| } | ||
| if (declaration.kind === SyntaxKind.JSDocPropertyTag && (<JSDocPropertyTag>declaration).typeExpression) { |
Contributor
There was a problem hiding this comment.
should not this be in getTypeForVariableLikeDeclarationFromJSDocComment?
Contributor
Author
There was a problem hiding this comment.
That method is originally for declarations written in the code whose type annotation in another seperated jsdoc comment, so other methods who call it all assumes VariableLikeDeclaration type of the declaration. It seems to be a lot of change to make all of them accept VariableLikeDeclaration | JSDocPropertyTag. What would be the benefit of doing that?
Contributor
There was a problem hiding this comment.
nothing specifically. it is just where all our get-type-from-jsdoc code.
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9620