Reorganize health assets#1307
Merged
Halterer merged 2 commits intoJun 28, 2019
Merged
Conversation
Renamed the following classes: GVFSEnlistmentHealthCalculator -> EnlistmentHealthCalculator GVFSEnlistmentPathData -> EnlistmentPathData GVFSEnlistmentHealthData -> EnlistmentHealthData Extracted EnlistmentPathData and EnlistmentHealthData to be standalone classes instead of inner classes of EnlistmentHealthCalculator. Created a GVFS.Common.HealthCalculator to house the 3 health classes
kewillford
reviewed
Jun 28, 2019
| /// with an optional parameter to only look for paths which are under the specified directory | ||
| /// </summary> | ||
| public class GVFSEnlistmentHealthCalculator | ||
| public partial class EnlistmentHealthCalculator |
Member
There was a problem hiding this comment.
Why is this class now partial?
Contributor
Author
There was a problem hiding this comment.
Oh whoops that was a line I missed when doing the refactoring. I tried to use the built in tools to extract inner classes, but it just created a new file and left them as members of EnlistmentHealthCalculator but in new files, hence why it was automatically modified to be a partial class. I missed that line when I went back through to change what had been automatically refactored.
Contributor
Author
There was a problem hiding this comment.
I'll very quickly push that fix up.
kewillford
approved these changes
Jun 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed the following classes:
GVFSEnlistmentHealthCalculator->EnlistmentHealthCalculatorGVFSEnlistmentPathData->EnlistmentPathDataGVFSEnlistmentHealthData->EnlistmentHealthDataExtracted
EnlistmentPathDataandEnlistmentHealthDatato be standaloneclasses instead of inner classes of
EnlistmentHealthCalculator.Created a
GVFS.Common.HealthCalculatordirectory to house the 3 health classes