Fix FastFetch MicroBuild signing for NativeAOT publish#1968
Merged
Conversation
With PublishAot=true, dotnet publish produces the native executable in $(PublishDir) rather than $(OutputPath). The FilesToSign items were still referencing $(OutputPath)\FastFetch.exe, causing the ESRP signing task to fail because the file doesn't exist at that path. Change the signing path to $(PublishDir) and remove the managed DLL entries (GVFS.Common.dll, GVFS.Platform.Windows.dll, GVFS.Virtualization.dll) which are statically linked into the native AOT binary and no longer exist as separate files. Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
tyrielv
force-pushed
the
tyrielv/fix-fastfetch-signing
branch
from
7382fed to
3e5fb28
Compare
derrickstolee
approved these changes
May 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
PublishAot=true,dotnet publishproduces the native executable in$(PublishDir)rather than$(OutputPath). TheFilesToSignitems inFastFetch.csprojwere still referencing$(OutputPath)\FastFetch.exe, causing the ESRP signing task to fail because the file doesn't exist at that path.Changes:
$(PublishDir)instead of$(OutputPath)for the signing pathGVFS.Common.dll,GVFS.Platform.Windows.dll,GVFS.Virtualization.dll) which are statically linked into the NativeAOT binary and no longer exist as separate filesThis is consistent with how
GVFS.Payloadhandles it — itslayout.batalready copies from thepublish\subdirectory and cleans up orphaned managed artifacts.