Skip to content

Fix Wrk CPU affinity process invocation and ParametersOn condition evaluation#690

Merged
RakeshwarK merged 3 commits intomicrosoft:mainfrom
RakeshwarK:wrkFix
Apr 13, 2026
Merged

Fix Wrk CPU affinity process invocation and ParametersOn condition evaluation#690
RakeshwarK merged 3 commits intomicrosoft:mainfrom
RakeshwarK:wrkFix

Conversation

@RakeshwarK
Copy link
Copy Markdown
Contributor

Issues fixed:

  • The original approach wrapped the numactl command via bash -c "numactl ... "args"", but wrk arguments contain embedded double quotes (e.g., --header "Accept: application/json"), which broke the nested quoting.
  • Override values from a ParametersOn section were merged into the evaluation context before the condition was evaluated, causing the condition itself to evaluate differently than intended.

@RakeshwarK RakeshwarK requested a review from brdeyo April 13, 2026 23:20
@RakeshwarK RakeshwarK merged commit c61a186 into microsoft:main Apr 13, 2026
5 checks passed
@RakeshwarK RakeshwarK deleted the wrkFix branch April 13, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants