"TypeError: read_tar() takes 3 positional arguments but 4 were given" when running validate-modern.py

[Antiz96]

Since these recent changes, the validate-modern.py script fails with TypeError: read_tar() takes 3 positional arguments but 4 were given.

It indeed seems like the read_tar function now expects 3 arguments while 4 arguments are passed from the main function.

[github-actions]

Logs are required for review from WSL team

If this a feature request, please reply with '/feature'. If this is a question, reply with '/question'.
Otherwise please attach logs by following the instructions below, your issue will not be reviewed unless they are added. These logs will help us understand what is going on in your machine.

How to collect WSL logs

Download and execute collect-wsl-logs.ps1 in an administrative powershell prompt:

Invoke-WebRequest -UseBasicParsing "https://raw.githubusercontent.com/microsoft/WSL/master/diagnostics/collect-wsl-logs.ps1" -OutFile collect-wsl-logs.ps1
Set-ExecutionPolicy Bypass -Scope Process -Force
.\collect-wsl-logs.ps1

The script will output the path of the log file once done.

If this is a networking issue, please use collect-networking-logs.ps1, following the instructions here

Once completed please upload the output files to this Github issue.

Click here for more info on logging
If you choose to email these logs instead of attaching to the bug, please send them to wsl-gh-logs@microsoft.com with the number of the github issue in the subject, and in the message a link to your comment in the github issue and reply with '/emailed-logs'.

[Antiz96]

Traceback (most recent call last):
  File "/builds/mark/archlinux-wsl/workdir/clone/distributions/validate-modern.py", line 499, in <module>
    main()
    ~~~~^^
  File "/builds/mark/archlinux-wsl/workdir/venv/lib/python3.13/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
           ~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/builds/mark/archlinux-wsl/workdir/venv/lib/python3.13/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/builds/mark/archlinux-wsl/workdir/venv/lib/python3.13/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builds/mark/archlinux-wsl/workdir/venv/lib/python3.13/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/builds/mark/archlinux-wsl/workdir/clone/distributions/validate-modern.py", line 68, in main
    read_tar(tar, '<none>', fd, ARM64_ELF_MAGIC if arm64 else  X64_ELF_MAGIC)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: read_tar() takes 3 positional arguments but 4 were given

[elsaco]

read_tar() is defined on line 323

WSL/distributions/validate-modern.py

Line 323 in 3af61d0

def read_tar(node, file, elf_magic: str):

but it's called by main() with four arguments, see line 68

WSL/distributions/validate-modern.py

Line 68 in 3af61d0

read_tar(tar, '<none>', fd, ARM64_ELF_MAGIC if arm64 else X64_ELF_MAGIC)

If you remove the 2nd argument '<none>' then the script works!

[mhegreberg]

I tested this fix locally and it seems to fix the issue for the Arch linux WSL Image

[OneBlue]

Thank you for reporting this !

Fixed by: #12707