Skip to content

Fix version typos in dev-loop.md#13950

Merged
OneBlue merged 1 commit intomicrosoft:masterfrom
mznms:fix-dev-loop
Dec 22, 2025
Merged

Fix version typos in dev-loop.md#13950
OneBlue merged 1 commit intomicrosoft:masterfrom
mznms:fix-dev-loop

Conversation

@mznms
Copy link
Contributor

@mznms mznms commented Dec 20, 2025

Summary of the Pull Request

Fix version typos in dev-loop.md (CMake 3.25, VS 2022)

PR Checklist

  • Closes: Link to issue Typos in dev-loop.md: incorrect CMake and Visual Studio version numbers #13949
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

This PR fixes two version typos in doc/docs/dev-loop.md:

  1. CMake version: 2.253.25

    • CMake 2.25 does not exist
    • Now consistent with CMakeLists.txt which specifies cmake_minimum_required(VERSION 3.25)
  2. MSVC toolset version: VS 2020VS 2022

    • VS 2020 does not exist
    • The v143 toolset corresponds to Visual Studio 2022

Validation Steps Performed

  • Verified CMake version matches CMakeLists.txt
  • Confirmed v143 toolset is Visual Studio 2022

Copilot AI review requested due to automatic review settings December 20, 2025 14:34
@mznms mznms requested a review from a team as a code owner December 20, 2025 14:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects two version typos in the developer documentation that referenced nonexistent software versions, ensuring the prerequisites accurately reflect the actual required tools.

  • Fixed CMake minimum version from the nonexistent 2.25 to the correct 3.25 (matching CMakeLists.txt)
  • Corrected MSVC toolset reference from the nonexistent VS 2020 to the correct VS 2022 (v143 toolset)

@OneBlue OneBlue merged commit f3125bb into microsoft:master Dec 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants