Skip to content

cleanup: fix typos and duplicated enum in wslaservice.idl#14195

Merged
benhillis merged 1 commit intofeature/wsl-for-appsfrom
user/benhill/wsla_idl_cleanup
Feb 11, 2026
Merged

cleanup: fix typos and duplicated enum in wslaservice.idl#14195
benhillis merged 1 commit intofeature/wsl-for-appsfrom
user/benhill/wsla_idl_cleanup

Conversation

@benhillis
Copy link
Copy Markdown
Member

I noticed a few minor typos and an enum that was duplicated (with the wrong enum type being used in one case).

@benhillis benhillis requested a review from a team as a code owner February 11, 2026 16:37
Copilot AI review requested due to automatic review settings February 11, 2026 16:37
@benhillis benhillis enabled auto-merge (squash) February 11, 2026 16:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up the WSLA service COM IDL by removing an unused/duplicated process state enum and fixing typos in enum constant names and comments, aligning the service implementation with the correct IDL-generated symbols.

Changes:

  • Removed the duplicated _WSLAProcessState typedef from wslaservice.idl in favor of the existing WSLA_PROCESS_STATE.
  • Fixed a typo in WSLAVirtualMachineTerminationReasonUnknown (previously spelled WSLAl...) and updated call sites accordingly.
  • Corrected a comment typo for WSLAContainerFlagsRm (“exists” → “exits”) and updated a process-state constant usage in WSLAContainer.cpp.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/windows/wslaservice/inc/wslaservice.idl Removes duplicated enum and fixes enum constant/comment typos to ensure consistent generated API surface.
src/windows/wslaservice/exe/WSLAContainer.cpp Uses the correct WSLA_PROCESS_STATE enum value (WslaProcessStateRunning) when deriving container state.
src/windows/wslaservice/exe/HcsVirtualMachine.cpp Fixes termination reason enum constant typo to match the IDL (WSLAVirtualMachineTerminationReasonUnknown).

@benhillis benhillis merged commit 901e9d2 into feature/wsl-for-apps Feb 11, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants