cleanup: fix typos and duplicated enum in wslaservice.idl#14195
Merged
benhillis merged 1 commit intofeature/wsl-for-appsfrom Feb 11, 2026
Merged
cleanup: fix typos and duplicated enum in wslaservice.idl#14195benhillis merged 1 commit intofeature/wsl-for-appsfrom
benhillis merged 1 commit intofeature/wsl-for-appsfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up the WSLA service COM IDL by removing an unused/duplicated process state enum and fixing typos in enum constant names and comments, aligning the service implementation with the correct IDL-generated symbols.
Changes:
- Removed the duplicated
_WSLAProcessStatetypedef fromwslaservice.idlin favor of the existingWSLA_PROCESS_STATE. - Fixed a typo in
WSLAVirtualMachineTerminationReasonUnknown(previously spelledWSLAl...) and updated call sites accordingly. - Corrected a comment typo for
WSLAContainerFlagsRm(“exists” → “exits”) and updated a process-state constant usage inWSLAContainer.cpp.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/windows/wslaservice/inc/wslaservice.idl |
Removes duplicated enum and fixes enum constant/comment typos to ensure consistent generated API surface. |
src/windows/wslaservice/exe/WSLAContainer.cpp |
Uses the correct WSLA_PROCESS_STATE enum value (WslaProcessStateRunning) when deriving container state. |
src/windows/wslaservice/exe/HcsVirtualMachine.cpp |
Fixes termination reason enum constant typo to match the IDL (WSLAVirtualMachineTerminationReasonUnknown). |
OneBlue
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a few minor typos and an enum that was duplicated (with the wrong enum type being used in one case).