virtio networking: add support for ipv6 by benhillis · Pull Request #14350 · microsoft/WSL

benhillis · 2026-03-04T02:56:38Z

This change adds support for ipv6 support to the virtioproxy networking mode. The changes here are primarily:

Update the WSL DeviceHost nuget package to a version that support specifying the 'client_ip_ipv6' address
Update VirtioProxy network engine to set the IPv6 address and gateway address.
Update wsl::core::networking::NetworkSettings class to keep track of IPv6 addresses and routes.

Copilot

Pull request overview

This PR adds IPv6 support to the VirtioProxy networking mode by extending host endpoint settings to track IPv6 configuration and wiring that into the Virtio networking engine, along with new Windows network tests validating IPv6 configuration and AAAA DNS resolution.

Changes:

Extend NetworkSettings/routes to track a preferred IPv6 address and an IPv6 default gateway.
Update VirtioProxy networking to plumb IPv6 address + IPv6 DNS servers into the guest, and to track an IPv6 default route.
Add VirtioProxy test coverage for IPv6 address/gateway configuration and AAAA DNS resolution.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
test/windows/NetworkTests.cpp	Adds VirtioProxy IPv6 configuration and AAAA DNS resolution tests.
src/windows/common/WslCoreNetworkEndpointSettings.h	Adds IPv6 fields/helpers to `NetworkSettings` and default-route helper.
src/windows/common/WslCoreNetworkEndpointSettings.cpp	Populates preferred IPv6 address + IPv6 default route from host adapter state.
src/windows/common/VirtioNetworking.h	Splits IP update into IPv4 vs IPv6 paths and tracks IPv6 default route.
src/windows/common/VirtioNetworking.cpp	Sends IPv6 address + IPv6 DNS + IPv6 default route updates to the guest.
packages.config	Bumps `Microsoft.WSL.DeviceHost` NuGet version to support `client_ip_ipv6`.

You can also share your feedback on Copilot code review. Take the survey.

src/windows/common/WslCoreNetworkEndpointSettings.cpp

src/windows/common/WslCoreNetworkEndpointSettings.h

src/windows/common/VirtioNetworking.cpp

src/windows/common/WslCoreNetworkEndpointSettings.cpp

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

You can also share your feedback on Copilot code review. Take the survey.

src/windows/common/WslCoreNetworkEndpointSettings.cpp

src/windows/common/VirtioNetworking.cpp

test/windows/NetworkTests.cpp

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

You can also share your feedback on Copilot code review. Take the survey.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

You can also share your feedback on Copilot code review. Take the survey.

src/windows/common/VirtioNetworking.cpp

src/windows/common/WslCoreNetworkEndpointSettings.h

- Add PreferredIpv6Address field and GetBestGatewayV6* methods to NetworkSettings - Extend GetHostEndpointSettings() to discover IPv6 unicast address and gateway - Add UpdateIpv6Address() using ModifyGuestEndpointSettingRequest<IPAddress> - Push IPv6 default route to guest via UpdateDefaultRoute(AF_INET6) - Remove AF_INET6 early return in ModifyOpenPorts, use INETADDR_PORT() - Add EndpointRoute::DefaultRoute() static factory - Pass client_ip_ipv6 in devicehost options (not yet parsed by devicehost) - Remove gateway_ip from devicehost options (only needed for DHCP) - Include IPv6 DNS servers in non-tunneling DNS settings - Add ConfigurationV6 and DnsResolutionAAAA tests

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

You can also share your feedback on Copilot code review. Take the survey.

src/windows/common/VirtioNetworking.cpp

test/windows/NetworkTests.cpp

src/windows/service/exe/WslCoreVm.cpp

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

You can also share your feedback on Copilot code review. Take the survey.

src/windows/common/VirtioNetworking.cpp

test/windows/NetworkTests.cpp

src/windows/common/WslCoreNetworkEndpointSettings.cpp

test/windows/NetworkTests.cpp

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

You can also share your feedback on Copilot code review. Take the survey.

test/windows/NetworkTests.cpp

src/windows/common/VirtioNetworking.cpp

test/windows/NetworkTests.cpp

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

You can also share your feedback on Copilot code review. Take the survey.

test/windows/NetworkTests.cpp

benhillis requested a review from a team as a code owner March 4, 2026 02:56

benhillis requested review from Brian-Perkins, OneBlue, Copilot, craigloewen-msft, damanm24, jstarks and justus-camp-microsoft March 4, 2026 02:56

Copilot started reviewing on behalf of benhillis March 4, 2026 02:57 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

benhillis requested a review from Copilot March 4, 2026 16:56

Copilot started reviewing on behalf of benhillis March 4, 2026 16:57 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

src/windows/common/WslCoreNetworkEndpointSettings.cpp Outdated Show resolved Hide resolved

src/windows/common/VirtioNetworking.cpp Outdated Show resolved Hide resolved

test/windows/NetworkTests.cpp Outdated Show resolved Hide resolved

Brian-Perkins previously approved these changes Mar 4, 2026

View reviewed changes

benhillis dismissed Brian-Perkins’s stale review via ce00933 March 4, 2026 17:37

benhillis requested a review from Copilot March 4, 2026 18:01

Copilot started reviewing on behalf of benhillis March 4, 2026 18:02 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

benhillis requested a review from Copilot March 5, 2026 01:12

Copilot started reviewing on behalf of benhillis March 5, 2026 01:14 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

OneBlue previously approved these changes Mar 7, 2026

View reviewed changes

src/windows/common/VirtioNetworking.cpp Outdated Show resolved Hide resolved

src/windows/common/WslCoreNetworkEndpointSettings.h Outdated Show resolved Hide resolved

Ben Hillis added 2 commits March 9, 2026 14:59

cleanup and add more ipv6 tests

5cd82fe

benhillis dismissed OneBlue’s stale review via 5cd82fe March 10, 2026 19:30

benhillis force-pushed the user/benhill/virtio_networking_ipv6 branch from ac9480f to 5cd82fe Compare March 10, 2026 19:30

added test coverage and minor updates

ac63004

Copilot AI review requested due to automatic review settings March 12, 2026 17:32

Copilot started reviewing on behalf of benhillis March 12, 2026 17:32 View session

clang format

2a359a9

Copilot AI reviewed Mar 12, 2026

View reviewed changes

pr feedback

941d137

benhillis requested a review from Copilot March 12, 2026 22:35

Copilot started reviewing on behalf of benhillis March 12, 2026 22:36 View session

format source

197236a

Copilot AI reviewed Mar 12, 2026

View reviewed changes

src/windows/common/VirtioNetworking.cpp Show resolved Hide resolved

test/windows/NetworkTests.cpp Outdated Show resolved Hide resolved

OneBlue previously approved these changes Mar 12, 2026

View reviewed changes

src/windows/common/WslCoreNetworkEndpointSettings.cpp Outdated Show resolved Hide resolved

test/windows/NetworkTests.cpp Outdated Show resolved Hide resolved

pr feedback

acb225a

benhillis dismissed OneBlue’s stale review via acb225a March 13, 2026 16:52

benhillis requested a review from Copilot March 13, 2026 16:52

Copilot started reviewing on behalf of benhillis March 13, 2026 16:53 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

test/windows/NetworkTests.cpp Outdated Show resolved Hide resolved

src/windows/common/VirtioNetworking.cpp Show resolved Hide resolved

test/windows/NetworkTests.cpp Outdated Show resolved Hide resolved

test fixes

3a57c71

benhillis requested a review from Copilot March 13, 2026 17:25

Copilot started reviewing on behalf of benhillis March 13, 2026 17:26 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

test/windows/NetworkTests.cpp Show resolved Hide resolved

test/windows/NetworkTests.cpp Show resolved Hide resolved

OneBlue approved these changes Mar 13, 2026

View reviewed changes

benhillis merged commit 7cd9ed9 into master Mar 13, 2026
10 checks passed

Conversation

benhillis commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants