Skip to content

Set container cursor#14516

Merged
AmelBawa-msft merged 3 commits intofeature/wsl-for-appsfrom
user/amelbawa/container-cursor
Mar 24, 2026
Merged

Set container cursor#14516
AmelBawa-msft merged 3 commits intofeature/wsl-for-appsfrom
user/amelbawa/container-cursor

Conversation

@AmelBawa-msft
Copy link
Copy Markdown
Contributor

Summary of the Pull Request

  • Set container cursor

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copilot AI review requested due to automatic review settings March 24, 2026 02:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a small RAII helper to ensure the Windows console cursor is visible while relaying an interactive container TTY session, restoring the previous cursor state when the relay ends.

Changes:

  • Introduce ScopedCursorVisibility to capture/restore CONSOLE_CURSOR_INFO and force cursor visibility during interactive relay.
  • Instantiate the new helper at the start of ConsoleService::RelayInteractiveTty.

@AmelBawa-msft AmelBawa-msft marked this pull request as ready for review March 24, 2026 04:56
@AmelBawa-msft AmelBawa-msft requested a review from a team as a code owner March 24, 2026 04:56
Copilot AI review requested due to automatic review settings March 24, 2026 04:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread src/windows/wslc/services/ContainerService.cpp
@AmelBawa-msft AmelBawa-msft enabled auto-merge (squash) March 24, 2026 05:14
Comment thread src/windows/wslc/services/ContainerService.cpp
@AmelBawa-msft AmelBawa-msft merged commit ab40395 into feature/wsl-for-apps Mar 24, 2026
11 checks passed
@AmelBawa-msft AmelBawa-msft deleted the user/amelbawa/container-cursor branch March 24, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants