Rename image delete to remove and add aliases#14521
Rename image delete to remove and add aliases#14521AmelBawa-msft merged 2 commits intofeature/wsl-for-appsfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the WSLC CLI to prefer image remove over image delete, while preserving backward compatibility via aliases and adding a new top-level rmi entry point.
Changes:
- Renames the primary image deletion command from
image deletetoimage remove, keepingdelete/rmas aliases. - Adds a new root-scoped
rmicommand for removing images. - Updates E2E help-output expectations to reflect the new command naming and alias display.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/windows/wslc/e2e/WSLCE2EImageDeleteTests.cpp | Updates expected help text/usage to image remove and includes alias section. |
| test/windows/wslc/e2e/WSLCE2EGlobalTests.cpp | Updates root help output expectations to include rmi. |
| src/windows/wslc/commands/RootCommand.cpp | Registers ImageRemoveCommand as a root-scoped rmi command. |
| src/windows/wslc/commands/ImageRemoveCommand.cpp | Renames command class implementation strings from delete→remove. |
| src/windows/wslc/commands/ImageCommand.h | Introduces ImageRemoveCommand (canonical remove, aliases delete/rm, root name rmi). |
| src/windows/wslc/commands/ImageCommand.cpp | Switches image subcommand registration from delete→remove. |
| src/windows/wslc/commands/ContainerCommand.h | Adds delete as an alias for ContainerRemoveCommand. |
OneBlue
left a comment
There was a problem hiding this comment.
LGTM. I recommend adding test coverage to validate that the aliases are wired (we could just check the help message for those specific commands here)
Good call, I think the test in this PR will fail after the new aliases show up. I will update them in the PR before completing it: |
Summary of the Pull Request
I also updated wslc container to support
deletein addition to theremovefor consistencyPR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed