diagnostics: switch log archive from zip to tar.gz#14530
Open
diagnostics: switch log archive from zip to tar.gz#14530
Conversation
benhillis
requested review from
OneBlue,
Copilot,
craigloewen-msft,
jstarks and
justus-camp-microsoft
Contributor
There was a problem hiding this comment.
Pull request overview
Switches WSL diagnostics log archival from Compress-Archive (.zip) to tar.exe (.tar.gz) to improve reliability for very large log sets.
Changes:
- Generate
.tar.gzarchives viatar.exe -czfinstead ofCompress-Archive - Add success/failure branching based on native exit code, including cleanup of partial archives
- Improve user-facing messaging when compression fails
OneBlue
reviewed
Mar 27, 2026
| tar.exe -czf $logArchive $folder | ||
| if ($LASTEXITCODE -eq 0) | ||
| { | ||
| Remove-Item $folder -Recurse |
Collaborator
There was a problem hiding this comment.
nit: I think we should fall back to zip if tar fails (in case this is ran on SKU's that might not have tar.exe)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves from using Compress-Archive to the inbox tar.exe. Compress-Archive can fail for very large files, so this approach will be more reliable.
This change also requires an update to WTI which I've published here: OneBlue/wti#5