[WSLC] add WSLC CMake file in NuGet#14543
Merged
chemwolf6922 merged 4 commits intofeature/wsl-for-appsfrom Mar 30, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a CMake package config file to the Microsoft.WSL.Containers NuGet layout so CMake-based consumers can find_package(Microsoft.WSL.Containers) and link against an imported SDK target.
Changes:
- Add
Microsoft.WSL.ContainersConfig.cmakeimplementingMicrosoft.WSL.Containers::sdkas an imported target. - Implement basic architecture detection (x64/arm64) and derive include/lib paths relative to the NuGet package root.
- Add validation for expected header/import library presence before defining the imported target.
ptrivedi
reviewed
Mar 26, 2026
ptrivedi
reviewed
Mar 26, 2026
ptrivedi
reviewed
Mar 26, 2026
ptrivedi
approved these changes
Mar 26, 2026
florelis
reviewed
Mar 26, 2026
florelis
approved these changes
Mar 27, 2026
Member
florelis
left a comment
There was a problem hiding this comment.
Looks good to me, aside from my comment about the file location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Add the CMake file in the WSLC NuGet package so developers can consume the sdk in CMake easier.
Example usage:
nuget install Microsoft.WSL.Containers -OutputDirectory .\packages -PrereleasePR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Tested locally with this minimal test app:
The test app compiles fine. And prints the not implemented error code as expected.