Update cgmanifest to match CMakeLists.txt#14550
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the component governance manifest (cgmanifest.json) to reflect the current CMake FetchContent-downloaded dependencies, and adds a reminder in CMakeLists.txt to keep the manifest in sync.
Changes:
- Remove the prior
git-based GSL registration fromcgmanifest.json. - Add
otherregistrations incgmanifest.jsonfor GSL v4.0.0 and nlohmann/json v3.12.0 (matching the CMake URLs/hashes). - Add a CMake note indicating dependency changes should be reflected in
cgmanifest.json.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cgmanifest.json | Updates governance registrations to include the current tarball-based FetchContent dependencies (GSL, nlohmann/json). |
| CMakeLists.txt | Adds a reminder comment to keep cgmanifest.json aligned with the FetchContent dependency declarations. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
benhillis
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change updates cgmanifest.json to match our current dependencies in CMakeLists.txt
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed