Skip to content

Update cgmanifest to match CMakeLists.txt#14550

Merged
OneBlue merged 2 commits intomasterfrom
user/oneblue/cgm
Mar 27, 2026
Merged

Update cgmanifest to match CMakeLists.txt#14550
OneBlue merged 2 commits intomasterfrom
user/oneblue/cgm

Conversation

@OneBlue
Copy link
Copy Markdown
Collaborator

@OneBlue OneBlue commented Mar 27, 2026

Summary of the Pull Request

This change updates cgmanifest.json to match our current dependencies in CMakeLists.txt

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copilot AI review requested due to automatic review settings March 27, 2026 02:09
@OneBlue OneBlue requested a review from a team as a code owner March 27, 2026 02:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the component governance manifest (cgmanifest.json) to reflect the current CMake FetchContent-downloaded dependencies, and adds a reminder in CMakeLists.txt to keep the manifest in sync.

Changes:

  • Remove the prior git-based GSL registration from cgmanifest.json.
  • Add other registrations in cgmanifest.json for GSL v4.0.0 and nlohmann/json v3.12.0 (matching the CMake URLs/hashes).
  • Add a CMake note indicating dependency changes should be reflected in cgmanifest.json.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
cgmanifest.json Updates governance registrations to include the current tarball-based FetchContent dependencies (GSL, nlohmann/json).
CMakeLists.txt Adds a reminder comment to keep cgmanifest.json aligned with the FetchContent dependency declarations.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 27, 2026 02:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@OneBlue OneBlue merged commit a13c157 into master Mar 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants