Skip to content

[CLI] Added support for entrypoint#14552

Merged
AmelBawa-msft merged 3 commits intofeature/wsl-for-appsfrom
user/amelbawa/entrypoint
Mar 27, 2026
Merged

[CLI] Added support for entrypoint#14552
AmelBawa-msft merged 3 commits intofeature/wsl-for-appsfrom
user/amelbawa/entrypoint

Conversation

@AmelBawa-msft
Copy link
Copy Markdown
Contributor

Summary of the Pull Request

  • Added support for entrypoint

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@AmelBawa-msft AmelBawa-msft requested a review from a team as a code owner March 27, 2026 04:43
Copilot AI review requested due to automatic review settings March 27, 2026 04:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds --entrypoint handling to the WSLC container create/run path, enabling callers to override the container init executable and validating behavior via new end-to-end tests.

Changes:

  • Parse --entrypoint from CLI args into ContainerOptions.
  • Pass ContainerOptions.Entrypoint into WSLAContainerLauncher when creating containers.
  • Add new e2e coverage for entrypoint scenarios (success, args forwarding, invalid path, detach lifecycle) and ensure Debian test image cleanup.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
test/windows/wslc/e2e/WSLCE2EContainerRunTests.cpp Adds e2e tests for --entrypoint and expands cleanup to delete the Debian test image.
src/windows/wslc/tasks/ContainerTasks.cpp Maps --entrypoint CLI argument into ContainerOptions.
src/windows/wslc/services/ContainerService.cpp Wires ContainerOptions.Entrypoint into container creation via WSLAContainerLauncher::SetEntrypoint.
src/windows/wslc/services/ContainerModel.h Extends ContainerOptions with an Entrypoint field.

Comment thread test/windows/wslc/e2e/WSLCE2EContainerRunTests.cpp
@AmelBawa-msft AmelBawa-msft enabled auto-merge (squash) March 27, 2026 17:22
Copilot AI review requested due to automatic review settings March 27, 2026 18:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Comment thread test/windows/wslc/e2e/WSLCE2EHelpers.cpp
Comment thread test/windows/wslc/e2e/WSLCE2EHelpers.cpp
@AmelBawa-msft AmelBawa-msft merged commit 92b8634 into feature/wsl-for-apps Mar 27, 2026
11 checks passed
@AmelBawa-msft AmelBawa-msft deleted the user/amelbawa/entrypoint branch March 28, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants