Skip to content

Use pre-imported container images in the tests to avoid hitting the API limit#14561

Merged
benhillis merged 3 commits intofeature/wsl-for-appsfrom
user/oneblue/no-pull
Mar 28, 2026
Merged

Use pre-imported container images in the tests to avoid hitting the API limit#14561
benhillis merged 3 commits intofeature/wsl-for-appsfrom
user/oneblue/no-pull

Conversation

@OneBlue
Copy link
Copy Markdown
Collaborator

@OneBlue OneBlue commented Mar 27, 2026

Summary of the Pull Request

This change updates our test to use the pre-installed test images instead of pulling from the docker registry

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copilot AI review requested due to automatic review settings March 27, 2026 23:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates WSLC tests to rely on pre-imported base images (instead of pulling from Docker Hub) to reduce registry/API-limit related failures in CI and local test runs.

Changes:

  • Switch Dockerfiles used in WSLC build-related tests from alpine to debian:latest.
  • Ensure the Debian test image is loaded for the WSLC E2E image build tests (and cleaned up afterward).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
test/windows/wslc/e2e/WSLCE2EImageBuildTests.cpp Loads the pre-imported Debian base image for E2E image-build tests and updates test Dockerfiles to FROM debian:latest.
test/windows/WSLCTests.cpp Updates multiple build-image API tests to use FROM debian:latest, aligning with images preloaded in test setup.

Comment thread test/windows/wslc/e2e/WSLCE2EImageBuildTests.cpp Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 27, 2026 23:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@benhillis benhillis merged commit e7c520e into feature/wsl-for-apps Mar 28, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants