socketshared: add maximum message size to avoid very large allocations#40050
Merged
socketshared: add maximum message size to avoid very large allocations#40050
Conversation
benhillis
requested review from
OneBlue,
Copilot,
craigloewen-msft,
damanm24 and
jstarks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a hard cap on inbound socket message sizes in the shared socket receive helper to prevent excessively large allocations from malformed or malicious senders.
Changes:
- Enforces a maximum single message size of 4 MiB in
RecvMessage()before resizing the receive buffer. - Throws/returns an error on oversized messages to avoid attempting large allocations.
OneBlue
approved these changes
Mar 31, 2026
| #if defined(_MSC_VER) | ||
| THROW_HR_MSG(E_UNEXPECTED, "Message size too large: %llu", MessageSize); | ||
| #elif defined(__GNUC__) | ||
| THROW_UNEXCEPTED(); |
Collaborator
There was a problem hiding this comment.
nit: might be a good idea to LOG_ERROR() here, to make root causing this easier if it ever hits on the linux side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a maximum single message size of 4MiB to the socket helpers. This avoids a potentially huge (4GB) allocation from a malicious or buggy sender.