Validate container path is absolute in VolumeMount::Parse#40085
Merged
benhillis merged 3 commits intofeature/wsl-for-appsfrom Apr 3, 2026
Merged
Validate container path is absolute in VolumeMount::Parse#40085benhillis merged 3 commits intofeature/wsl-for-appsfrom
benhillis merged 3 commits intofeature/wsl-for-appsfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation that non-empty container paths must start with '/' since they are Linux paths inside the container. This catches cases where Windows drive letter colons (e.g. C:\path) get misinterpreted as the host:container separator, producing invalid container paths like '\hostPath' instead of '/containerPath'.
Previously, 'C:\hostPath:ro' would silently parse as host='C', container='\hostPath', mode=ro - now it throws a clear error.
Updated tests to reflect the new validation and moved previously 'valid' but semantically incorrect cases to a new VolumeMount_Parse_InvalidContainerPath test.