Fix race condition when building multiple IDL files#40130
Merged
OneBlue merged 5 commits intofeature/wsl-for-appsfrom Apr 8, 2026
Merged
Fix race condition when building multiple IDL files#40130OneBlue merged 5 commits intofeature/wsl-for-appsfrom
OneBlue merged 5 commits intofeature/wsl-for-appsfrom
Conversation
yao-msft
approved these changes
Apr 7, 2026
yao-msft
left a comment
There was a problem hiding this comment.
Recently every time I rebuild I hit this
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to address a parallel-build race involving MIDL-generated dlldata*.c by adding ordering constraints between successive IDL compilation steps in the CMake IDL helper module.
Changes:
- Add a dependency chain (
DEPENDS ... ${PREVIOUS_OUTPUT}) between MIDL custom commands to force sequential execution. - Track the prior MIDL outputs via a new
PREVIOUS_OUTPUTvariable.
Collaborator
Author
Same ! |
benhillis
approved these changes
Apr 8, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change solves a build failure that happens because multiple processes write do
dlldata*.cas the same time. This change solves the issue by making sure that they don't run at the same timePR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed