Skip to content

Update volume APIs to match docker arguments#40181

Merged
kvega005 merged 11 commits intomicrosoft:feature/wsl-for-appsfrom
kvega005:volumeManagement
Apr 15, 2026
Merged

Update volume APIs to match docker arguments#40181
kvega005 merged 11 commits intomicrosoft:feature/wsl-for-appsfrom
kvega005:volumeManagement

Conversation

@kvega005
Copy link
Copy Markdown

Summary of the Pull Request

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copilot AI review requested due to automatic review settings April 14, 2026 22:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@kvega005 kvega005 requested a review from Copilot April 15, 2026 01:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 8 comments.

Comment thread src/windows/common/wslutil.cpp
Comment thread src/windows/wslcsession/WSLCSession.cpp Outdated
Comment thread src/windows/wslcsession/WSLCSession.cpp Outdated
Comment thread src/windows/wslcsession/WSLCVhdVolume.cpp
Comment thread src/windows/wslcsession/WSLCVhdVolume.h Outdated
Comment thread src/windows/wslcsession/WSLCVhdVolume.cpp Outdated
Comment thread localization/strings/en-US/Resources.resw Outdated
Comment thread src/windows/wslcsession/WSLCSession.cpp Outdated
@kvega005 kvega005 marked this pull request as ready for review April 15, 2026 01:46
@kvega005 kvega005 requested a review from a team as a code owner April 15, 2026 01:46
Copy link
Copy Markdown
Collaborator

@OneBlue OneBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks great! Couple minor comments

Comment thread src/windows/wslcsession/WSLCVhdVolume.cpp Outdated
Comment thread test/windows/WSLCTests.cpp
Comment thread src/windows/service/inc/wslc.idl
Comment thread src/windows/wslcsession/WSLCVhdVolume.cpp Outdated
Copilot AI review requested due to automatic review settings April 15, 2026 06:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 8 comments.

Comment thread src/windows/wslcsession/WSLCVhdVolume.cpp Outdated
Comment thread src/windows/wslcsession/WSLCVhdVolume.cpp
Comment thread src/windows/wslcsession/WSLCVhdVolume.cpp
Comment thread src/windows/wslcsession/WSLCVhdVolume.cpp
Comment thread test/windows/WSLCTests.cpp
Comment thread test/windows/WSLCTests.cpp Outdated
Comment thread src/windows/common/wslutil.cpp
Comment thread src/windows/wslcsession/WSLCSession.cpp
Copilot AI review requested due to automatic review settings April 15, 2026 17:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 9 comments.

Comment thread src/windows/wslcsession/WSLCVhdVolume.cpp
Comment thread src/windows/service/inc/wslc.idl
Comment thread src/windows/service/inc/wslc.idl
Comment thread src/windows/wslcsession/WSLCSession.cpp
Comment thread src/windows/wslcsession/WSLCSession.cpp
Comment thread src/windows/wslcsession/WSLCVhdVolume.cpp
Comment thread src/windows/wslcsession/WSLCVhdVolume.cpp
Comment thread src/windows/common/wslutil.cpp
Comment thread src/windows/common/wslutil.cpp
@kvega005 kvega005 merged commit fb132be into microsoft:feature/wsl-for-apps Apr 15, 2026
10 of 11 checks passed
@kvega005 kvega005 deleted the volumeManagement branch April 15, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants