Fix std::format type mismatch mixing std::wstring and std::string#40201
Closed
benhillis wants to merge 1 commit intofeature/wsl-for-appsfrom
Closed
Fix std::format type mismatch mixing std::wstring and std::string#40201benhillis wants to merge 1 commit intofeature/wsl-for-appsfrom
benhillis wants to merge 1 commit intofeature/wsl-for-appsfrom
Conversation
In WSLCContainer::Create, the bind source path for file mounts was constructed using std::format with a narrow format string but passing sourceFilename (std::wstring) alongside parentVMPath (std::string). This is a type mismatch in standard C++20 std::format. Convert sourceFilename to narrow string via WideToMultiByte before formatting to ensure type consistency and correct behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
benhillis
force-pushed
the
copilot/fix/wstring-format-mismatch
branch
from
e98270b to
d5f1eb8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a std::format argument type mismatch in WSLCContainerImpl::Create() when constructing the Docker bind source path for file mounts by ensuring the filename portion is converted from std::wstring to std::string before formatting.
Changes:
- Convert
sourceFilename(std::wstring) to UTF-8std::stringviawsl::shared::string::WideToMultiByte()when buildingbindSourcefor file mounts. - Reformat the ternary for
bindSourceinto a multi-line expression for readability.
AmelBawa-msft
approved these changes
Apr 16, 2026
JohnMcPMS
approved these changes
Apr 16, 2026
OneBlue
requested changes
Apr 16, 2026
Collaborator
There was a problem hiding this comment.
I don't think this is true (although AIs seem to flag this a lot).
We have a set of custom formatters that handle narrow <-> wide string conversion for us. We use them all across the codebase
Member
Author
|
Pierre is right on the custom formatters. Copilot was wrong on this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
WSLCContainer::Create(), the bind source path for file mounts is constructed usingstd::formatwith a narrow format string but passingsourceFilename(std::wstring) alongsideparentVMPath(std::string).std::formatwith a narrow format string does not acceptstd::wstringarguments in standard C++20. This is a type mismatch that could cause compilation failures or undefined behavior.Fix
Convert
sourceFilenamefromstd::wstringtostd::stringviaWideToMultiByte()before passing it tostd::format, consistent with how the codebase handles wide-to-narrow conversions elsewhere.Testing
Type-correctness fix in the volume bind path construction for file mounts (introduced in #40137).