CLI: Unit test to ensure no argument name or alias collisions exist#40312
Merged
dkbennett merged 4 commits intofeature/wsl-for-appsfrom Apr 24, 2026
Merged
CLI: Unit test to ensure no argument name or alias collisions exist#40312dkbennett merged 4 commits intofeature/wsl-for-appsfrom
dkbennett merged 4 commits intofeature/wsl-for-appsfrom
Conversation
6 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a CLI unit test that walks the command tree from the root and asserts that argument names and aliases are unique per command, preventing ambiguous CLI argument parsing.
Changes:
- Added a breadth/depth traversal over the CLI command tree starting at
RootCommand. - Added per-command checks for duplicate argument long names and short aliases.
AmelBawa-msft
approved these changes
Apr 24, 2026
yao-msft
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Simple test that walks the CLI command tree and ensures no commands have ambiguous names or aliases that map to different arguments.
Example of finding a collision (I intentionally gave session the same alias as help to force a collision)

Example of no collisions (the above alias removed)

PR Checklist
Detailed Description of the Pull Request / Additional comments
Walks the command tree from the Root and examines arguments of each command and ensures there are no duplicate names or aliases in any of them.
Validation Steps Performed
Test passes!