Skip to content

Fixed leaked container in NamedVolumesVhdSessionRecovery causing test failures in OpenContainer#40316

Merged
benhillis merged 2 commits intofeature/wsl-for-appsfrom
user/oneblue/test-fix-7
Apr 25, 2026
Merged

Fixed leaked container in NamedVolumesVhdSessionRecovery causing test failures in OpenContainer#40316
benhillis merged 2 commits intofeature/wsl-for-appsfrom
user/oneblue/test-fix-7

Conversation

@OneBlue
Copy link
Copy Markdown
Collaborator

@OneBlue OneBlue commented Apr 24, 2026

Summary of the Pull Request

This change fixes a leaked container in the NamedVolumesVhdSessionRecovery test case. If the first character of the container ID collided with the one that OpenContainer() creates, this would create a test failure du to an ambiguous prefix

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copilot AI review requested due to automatic review settings April 24, 2026 22:36
@OneBlue OneBlue requested a review from a team as a code owner April 24, 2026 22:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a WSLC Windows test leak in NamedVolumesVhdSessionRecovery that could leave a container behind and interfere with later OpenContainer()-related test behavior.

Changes:

  • Add a scope-exit cleanup in NamedVolumesVhdSessionRecovery to prune containers at the end of the test.
  • Minor formatting adjustment (blank line) in the test method.

Comment thread test/windows/WSLCTests.cpp Outdated
@benhillis benhillis merged commit 19a757f into feature/wsl-for-apps Apr 25, 2026
8 checks passed
@benhillis benhillis deleted the user/oneblue/test-fix-7 branch April 25, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants