Fixed leaked container in NamedVolumesVhdSessionRecovery causing test failures in OpenContainer#40316
Merged
benhillis merged 2 commits intofeature/wsl-for-appsfrom Apr 25, 2026
Merged
Conversation
… failures in OpenContainer
AmelBawa-msft
approved these changes
Apr 24, 2026
benhillis
approved these changes
Apr 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a WSLC Windows test leak in NamedVolumesVhdSessionRecovery that could leave a container behind and interfere with later OpenContainer()-related test behavior.
Changes:
- Add a scope-exit cleanup in
NamedVolumesVhdSessionRecoveryto prune containers at the end of the test. - Minor formatting adjustment (blank line) in the test method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change fixes a leaked container in the
NamedVolumesVhdSessionRecoverytest case. If the first character of the container ID collided with the one that OpenContainer() creates, this would create a test failure du to an ambiguous prefixPR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed