Modify CreateRestrictedToken to use better pattern#40453
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates WSL’s restricted-token creation logic to align with the shared SID-construction helper and to use a consistent SetTokenInformation sizing pattern within the Windows security utilities.
Changes:
- Replaced manual
SIDbuffer/RtlInitializeSidExusage with the existingCreateSid(...)helper when setting token integrity level. - Updated
SetTokenInformation(TokenIntegrityLevel, ...)to passsizeof(TOKEN_MANDATORY_LABEL)for the token information length.
OneBlue
approved these changes
May 7, 2026
benhillis
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Switch CreateRestrictedToken to a newer pattern for consistency.
Detailed Description of the Pull Request / Additional comments
Use the CreateSid wrapper and only pass the size of the token information class to SetTokenInformation.
Validation Steps Performed
Manually started WSL