Pass tv_sec and tv_nsec to LxtLogError in CheckTime#40494
Merged
benhillis merged 1 commit intoMay 12, 2026
Conversation
The format string takes four scalars (sec, nsec, sec, nsec) but only two struct timespec pointers were being passed, so the diagnostic on failure printed garbage. Pass the four scalar fields with explicit casts to match the format specifiers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes undefined varargs usage in a unit test failure diagnostic by passing timespec scalar fields (tv_sec, tv_nsec) to LxtLogError in the expected types.
Changes:
- Update
LxtLogErrorcall inCheckTimeto passTimestamp{1,2}->tv_secand->tv_nsecwith casts matching the format string.
5 tasks
OneBlue
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #40489.
When
LxtFsTimestampDiffindicates thatTimestamp1is not strictly greater thanTimestamp2, the failure path calledLxtLogErrorwith a format string expecting four scalars (sec,nsec,sec,nsec) but only passed the twostruct timespec*pointers. The diagnostic therefore printed garbage on test failure, and the call relies on undefined varargs behavior.Change
test/linux/unit_tests/lxtfs.c: passTimestamp{1,2}->tv_secand->tv_nsecwith(long long)/(long)casts so the format string matches the arguments.Validation