Skip localization PR creation on file-change CI trigger#40501
Merged
Conversation
The nightly localization pipeline runs both on schedule and when localization/strings/en-US/Resources.resw is updated. The CI-triggered run produces a no-op Touchdown pass that still creates a PR, consuming build resources without updating any strings. Gate the Create-PR step on Build.Reason in (Schedule, Manual) so the PR is only created for the nightly schedule (and manual runs), not when the pipeline is triggered by a push to Resources.resw. Follow-up to #40499 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the nightly localization Azure DevOps pipeline to avoid creating follow-up GitHub localization PRs when the pipeline is triggered by a path-based CI run (i.e., a push that modifies localization/strings/en-US/Resources.resw), while preserving PR creation for scheduled and manual runs.
Changes:
- Gates the
Create pull requeststep so it only runs whenBuild.ReasonisScheduleorManual.
OneBlue
previously approved these changes
May 11, 2026
The pip auth step only exists to support create-change.py; if we're not creating a PR there's no reason to authenticate to the pip feed. Keep TouchdownBuildTask running on file-change CI so new source strings are still submitted to the translation service. Addresses review feedback from @OneBlue. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
OneBlue
requested changes
May 11, 2026
Collaborator
OneBlue
left a comment
OneBlue
left a comment
There was a problem hiding this comment.
The latest iteration is missing the condition on the pip install invocation (which will fail without the pip authenticate part)
OneBlue
approved these changes
May 11, 2026
Collaborator
OneBlue
left a comment
OneBlue
left a comment
There was a problem hiding this comment.
My previous review was wrong !
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gate the
Create pull requeststep in the nightly localization pipeline onBuild.Reason in (Schedule, Manual)so it does not run when the pipeline is triggered by a push that modifiedlocalization/strings/en-US/Resources.resw.Without this, every change to
Resources.resw(e.g., #40499) kicks off the pipeline, which then runs Touchdown and opens a follow-up localization PR even though there are no new strings to localize. Those PRs consume build resources without changing any localized strings.After this change: