Italian Translation - Ch. 5

[robertopauletto]

Hi,

just a thought regarding the extension installation instructions: maybe it's worth specify that you have to enable "Developer mode" first in order to see "Load unpacked", by default this mode is disabled. You can see this in the screenshot anyway but after all we are addressing beginners...

1-about browser

• After "Take a minute to look through the codebase:" may a code block directive is missing when you specify the directory structure of the app?

• "build your extension using npm build" should be "build your extension using npm run build"?

3-background task and performance

• This link is broken:
  You'll learn more about the Canvas API in the Space Game lessons.
  I think should be
  You'll learn more about the Canvas API in the Space Game lessons.

Thanks!

[jlooper]

Cc @softchris - I love how the translations help clarify the English instructions 😍

[jlooper]

hi @robertopauletto question - I don't think we want to translate the code in the /dist folder of the browser extension, not sure what you are proposing here?

[robertopauletto]

I'm sorry, I realize that I have not been clear. First of all, I forgot to translate the readme.md in the /solution/dist folder, which I have done now. I was referring to the comments, labels and strings in the html and js files for the /solution/dist folder. For the start folder it's ok because the student can follow along more clearly but for the final solution code I was not sure if I have to do this. If you don't want the translations in the start/dist folder too, just ignore it. -- Roberto Pauletto roberto.pauletto@gmail.com

…

On Thu, Jan 28, 2021, at 17:42, Jen Looper wrote: ***@***.**** commented on this pull request. hi @robertopauletto <https://github.com/robertopauletto> question - I don't think we want to translate the code in the /dist folder of the browser extension, not sure what you are proposing here? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#177 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFJRFB4KOH5VPCJO45KTFLS4GHYDANCNFSM4WQMGKRQ>.

[han9912]

@jlooper @robertopauletto Hi, thanks for the translation! But I think it's necessary to use English to avoid confusion, when there's no specification that it's a translation. So I open #915 to revert the translation to English.
Awaiting your review, thanks.

[robertopauletto]

HI, fine by me Bye

…

-- Roberto Pauletto ***@***.***

On Thu, Oct 20, 2022, at 10:50, inlite wrote: @jlooper <https://github.com/jlooper> @robertopauletto <https://github.com/robertopauletto> Hi, thanks for the translation! But I think it's necessary to use English to avoid confusion, when there's no specification that it's a translation. So I open pull request <https://app.fastmail.com/mail/Inbox/compose?u=1f904155#915> to revert the translation to English. Awaiting your review, thanks. — Reply to this email directly, view it on GitHub <#177 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFJRFAIY7L2V7OFTMICZNLWEEBW3ANCNFSM4WQMGKRQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[jlooper]

I'm no longer a maintainer but thank you for your continued work here 💓