Added French File#367
Conversation
aryasoni98
commented
Aug 23, 2021
|
@ManuSquall would you take a look please? |
|
Sure, on it |
ManuSquall
left a comment
There was a problem hiding this comment.
Thanks for the translation @aryasoni98. Please don't forget to refer the french files in the links and the quiz. I let some reviews on your first translated file.
|
@ManuSquall Sir please review my PR |
ManuSquall
left a comment
There was a problem hiding this comment.
@aryasoni98 most of my reviews havn't been considered, so please recheck them, i also noticed that you changed an english basic file, maybe you should make it in another PR or change the title of this one?
Please yours link to the assignments and the quiz have also to refer the french one.
| Il y a une poignée de bonnes pratiques à garder à l'esprit lors de la création de fonctions | ||
|
|
||
| - Comme toujours, utilisez des noms descriptifs pour savoir ce que la fonction fera | ||
| - Utilisez **boîte de chameau** pour combiner des mots |
There was a problem hiding this comment.
boîte de chameau doesn't have sense here from my point of vue, the camelCase word is also used in french and boîte de chameau is not appropriated for the context i think
|
@aryasoni98 it seems you have done some changes on the basics english files in your "added french file" PR: |
|
Is it possible for me to edit your files or i have to fork your repo? |
|
plugins { android { } dependencies { } |
|
I'm going to close this as I don't think the proper procedures are being followed per @ManuSquall 's instructions and the thread is attracting spam |
