Skip to content

Added French File#367

Closed
aryasoni98 wants to merge 3 commits intomicrosoft:mainfrom
aryasoni98:main
Closed

Added French File#367
aryasoni98 wants to merge 3 commits intomicrosoft:mainfrom
aryasoni98:main

Conversation

@aryasoni98
Copy link

  • Base README.md

  • for-teachers.md

  • Quizzes

  • 1-getting-started-lessons base README

    • intro-to-programming-languages README
    • intro-to-programming-languages assignment
    • github-basics README
    • accessibility README
    • accessibility assignment
  • 2-js-basics base README

    • data-types README
    • data-types assignment
    • [x ] functions-methods README
    • functions-methods assignment
    • [] making-decisions README
    • making-decisions assignment
    • arrays-loops README
    • arrays-loops assignment
  • 3-terrarium base README

    • intro-to-html README
    • intro-to-html assignment
    • intro-to-css README
    • intro-to-css assignment
    • intro-to-DOM-and-closures README
    • intro-to-DOM-and-closures assignment
  • 4-typing-game base README

    • typing-game README
    • typing-game assignment
  • 5-browser-extension base README

    • about-browsers README
    • about-browsers assignment
    • forms-browsers-local-storage README
    • forms-browsers-local-storage assignment
    • background-tasks-and-performance README
    • background-tasks-and-performance assignment
    • solution base README
    • start base README
  • 6-space-game base README

    • introduction README
    • introduction assignment
    • drawing-to-canvas README
    • drawing-to-canvas assignment
    • moving-elements-around README
    • moving-elements-around assignment
    • collision-detection README
    • collision-detection assignment
    • keeping-score README
    • keeping-score assignment
    • end-condition README
    • end-condition assignment
  • 7-bank-project base README

    • template-route README
    • template-route assignment
    • forms README
    • forms assignment
    • data README
    • data assignment
    • state-management README
    • state-management assignment
    • solution base README
  • Base README.md

  • for-teachers.md

  • Quizzes

  • 1-getting-started-lessons base README

    • intro-to-programming-languages README
    • intro-to-programming-languages assignment
    • github-basics README
    • accessibility README
    • accessibility assignment
  • 2-js-basics base README

    • data-types README
    • data-types assignment
    • functions-methods README
    • functions-methods assignment
    • making-decisions README
    • making-decisions assignment
    • arrays-loops README
    • arrays-loops assignment
  • 3-terrarium base README

    • intro-to-html README
    • intro-to-html assignment
    • intro-to-css README
    • intro-to-css assignment
    • intro-to-DOM-and-closures README
    • intro-to-DOM-and-closures assignment
  • 4-typing-game base README

    • typing-game README
    • typing-game assignment
  • 5-browser-extension base README

    • about-browsers README
    • about-browsers assignment
    • forms-browsers-local-storage README
    • forms-browsers-local-storage assignment
    • background-tasks-and-performance README
    • background-tasks-and-performance assignment
    • solution base README
    • start base README
  • 6-space-game base README

    • introduction README
    • introduction assignment
    • drawing-to-canvas README
    • drawing-to-canvas assignment
    • moving-elements-around README
    • moving-elements-around assignment
    • collision-detection README
    • collision-detection assignment
    • keeping-score README
    • keeping-score assignment
    • end-condition README
    • end-condition assignment
  • 7-bank-project base README

    • template-route README
    • template-route assignment
    • forms README
    • forms assignment
    • data README
    • data assignment
    • state-management README
    • state-management assignment
    • solution base README

@ghost
Copy link

ghost commented Aug 23, 2021

CLA assistant check
All CLA requirements met.

@jlooper
Copy link
Contributor

jlooper commented Aug 24, 2021

@ManuSquall would you take a look please?

@ManuSquall
Copy link
Contributor

Sure, on it

Copy link
Contributor

@ManuSquall ManuSquall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation @aryasoni98. Please don't forget to refer the french files in the links and the quiz. I let some reviews on your first translated file.

@aryasoni98
Copy link
Author

@ManuSquall Sir please review my PR

Copy link
Contributor

@ManuSquall ManuSquall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aryasoni98 most of my reviews havn't been considered, so please recheck them, i also noticed that you changed an english basic file, maybe you should make it in another PR or change the title of this one?

Please yours link to the assignments and the quiz have also to refer the french one.

Il y a une poignée de bonnes pratiques à garder à l'esprit lors de la création de fonctions

- Comme toujours, utilisez des noms descriptifs pour savoir ce que la fonction fera
- Utilisez **boîte de chameau** pour combiner des mots
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boîte de chameau doesn't have sense here from my point of vue, the camelCase word is also used in french and boîte de chameau is not appropriated for the context i think

@ManuSquall
Copy link
Contributor

@aryasoni98 it seems you have done some changes on the basics english files in your "added french file" PR:

image

@ManuSquall
Copy link
Contributor

Is it possible for me to edit your files or i have to fork your repo?

@saan2
Copy link

saan2 commented Aug 31, 2021

plugins {
id 'com.android.application'
id 'kotlin-android'
}

android {
compileSdkVersion 30
buildToolsVersion "30.0.3"

defaultConfig {
    applicationId "com.aespaes.sck"
    minSdkVersion 21
    targetSdkVersion 30
    versionCode 1
    versionName "1.0"

    testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
}

buildTypes {
    release {
        minifyEnabled false
        proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
    }
}
compileOptions {
    sourceCompatibility JavaVersion.VERSION_1_8
    targetCompatibility JavaVersion.VERSION_1_8
}
kotlinOptions {
    jvmTarget = '1.8'
}

}

dependencies {

implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
implementation 'androidx.core:core-ktx:1.6.0'
implementation 'androidx.appcompat:appcompat:1.3.0'
implementation 'com.google.android.material:material:1.4.0'
implementation 'androidx.constraintlayout:constraintlayout:2.0.4'
testImplementation 'junit:junit:4.+'
androidTestImplementation 'androidx.test.ext:junit:1.1.3'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'

implementation 'com.google.firebase:firebase-ads:20.2.0'
implementation 'com.facebook.android:audience-network-sdk:6.+'

}

@jlooper
Copy link
Contributor

jlooper commented Sep 3, 2021

I'm going to close this as I don't think the proper procedures are being followed per @ManuSquall 's instructions and the thread is attracting spam

@jlooper jlooper closed this Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants