Skip to content

Create README.tr.md#729

Closed
subnwa wants to merge 1 commit intomicrosoft:mainfrom
subnwa:patch-1
Closed

Create README.tr.md#729
subnwa wants to merge 1 commit intomicrosoft:mainfrom
subnwa:patch-1

Conversation

@subnwa
Copy link

@subnwa subnwa commented Sep 13, 2022

This is a README file translated into Turkish.

The file 5-browser-extension/translations/README.tr.md has been created.

This is a README file translated into Turkish.

The file 5-browser-extension/translations/README.tr.md has been created.
@ghost
Copy link

ghost commented Sep 13, 2022

CLA assistant check
All CLA requirements met.

@subnwa
Copy link
Author

subnwa commented Sep 14, 2022

@sinedied @softchris Please see the content

Copy link
Collaborator

@saragibby saragibby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this translation @subnwa! There are a few changes to be made, and then we can do a review to get this merged.


Edge, Chrome ve Firefox'ta çalışan bir tarayıcı uzantısı oluşturacaksınız. Çok özel bir görev için tasarlanmış mini bir web sitesine benzeyen bu uzantı, belirli bir bölgenin elektrik kullanımı ve karbon yoğunluğu için [C02 sinyal API'sini](https://www.co2signal.com) kontrol eder.

Edge, Chrome ve Firefox'ta çalışan bir tarayıcı uzantısı oluşturacaksınız. Çok özel bir göreve uyarlanmış mini bir web sitesine benzeyen bu uzantı, belirli bir bölgenin elektrik tüketimi ve karbon yoğunluğu için [C02 Signal API'sini](https://www.co2signal.com) kontrol eder ve bölgenin karbon ayak izi hakkında bir yazı gösterir.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph appears to be a near duplicate of the one above, instead of the 3 paragraph of instruction in the lesson.


### Konular

1. [Tarayıcı hakkında](about-browsers/README.md)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this readme will be within the "translations" folder, these 3 links will need to be prefixed with "../" to navigate back to the main folder.

Also, these 3 links are missing the number in their URL path.

For example, this link should be [Tarayıcı hakkında](../1-about-browsers/README.md)

@saragibby saragibby added the changes requested Requested changes to pull request label Jan 9, 2023
@saragibby saragibby self-assigned this Jan 9, 2023
@subnwa subnwa closed this by deleting the head repository Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes requested Requested changes to pull request translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants