Removing number from selection pages #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmingoh
requested review from
KirillShchetinin,
crutkas,
dgomezc,
markAtMicrosoft,
mvegaca,
sibille,
smmatte and
tejbirsingh
as code owners
jasmingoh
requested review from
Tanya0609,
annielovesjs,
jsondoo and
streetcoder123
piotrmark
suggested changes
May 28, 2019
piotrmark
previously approved these changes
May 28, 2019
SahilTara
suggested changes
May 28, 2019
added 2 commits
May 28, 2019 17:09
…icrosoft/WebTemplateStudio into garage/t-ligoh/issue-622-remove-number
annielovesjs
approved these changes
May 29, 2019
Contributor
annielovesjs
left a comment
annielovesjs
left a comment
There was a problem hiding this comment.
looks good! All the changes are evident and everything runs perfectly
piotrmark
approved these changes
May 29, 2019
SahilTara
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving issue 662 (#622)
Talked to Christina (designer on the team) about having numbers on the selection pages. We looked at Windows Template Studio as reference, and found out that they do not have numbers on the selection pages. Hence, we decided to make this change.
Here's the before and after for the Frameworks page:
Please note: GitHub issue 662 only mentioned the Frameworks page, but this PR includes changes to other pages as well (i.e. the Project Type page, Pages page, Services page and Summary page).