This repository was archived by the owner on May 28, 2025. It is now read-only.
Fix [GitHub Issue #1451] Canabalt [ARM-x86]: blocked at splash screen#1471
Merged
yiyang-msft merged 2 commits intodevelopfrom Nov 30, 2016
Merged
Fix [GitHub Issue #1451] Canabalt [ARM-x86]: blocked at splash screen#1471yiyang-msft merged 2 commits intodevelopfrom
yiyang-msft merged 2 commits intodevelopfrom
Conversation
tadam-msft
reviewed
Nov 30, 2016
| pSuper->priv->removeChild(self); | ||
|
|
||
| [pSuper setNeedsLayout]; | ||
| [self release]; |
Member
There was a problem hiding this comment.
Looks good, can we get a XAMLCatalog sample that would demonstrate this issue 100%--maybe on a new "Bugs" section #Pending
Contributor
Author
There was a problem hiding this comment.
I have a repro and a test case in progress. will check it in separately.
In reply to: 90150570 [](ancestors = 90150570)
jaredhms
reviewed
Nov 30, 2016
| pSuper->priv->removeChild(self); | ||
|
|
||
| [pSuper setNeedsLayout]; | ||
| [self release]; |
Contributor
There was a problem hiding this comment.
[self release]; [](start = 4, length = 15)
wow - that's kind of odd. you'd think that the superlayer would be holding the reference....? #WontFix
Contributor
Author
There was a problem hiding this comment.
indeed strange. we will re-visit its usage pattern later though.
In reply to: 90150584 [](ancestors = 90150584)
Contributor
Contributor
|
|
oliversa-msft
approved these changes
Nov 30, 2016
tadam-msft
pushed a commit
to tadam-msft/WinObjC
that referenced
this pull request
Nov 30, 2016
…sh screen (microsoft#1471) * Fix [GitHub Issue microsoft#1451] Canabalt [ARM-x86]: blocked at splash screen * comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue here is that when a sublayer is removed from super, we need call setNeedsLayout which will flush out corresponding transactions to update the view hierarchy.
This is based on the observation from reference platform when removing layer. The following call sequence is happening.
[subLayer removeFromSuper] triggers the following call sequence
[CALayer setNeedsLayout] -> [CALayer drawInContext] ->[UIView drawRect]
This change is